From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LgLD4-0005z0-NG for qemu-devel@nongnu.org; Sun, 08 Mar 2009 11:46:38 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LgLD2-0005tU-3d for qemu-devel@nongnu.org; Sun, 08 Mar 2009 11:46:37 -0400 Received: from [199.232.76.173] (port=54702 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LgLD2-0005tI-0B for qemu-devel@nongnu.org; Sun, 08 Mar 2009 11:46:36 -0400 Received: from fg-out-1718.google.com ([72.14.220.155]:15157) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LgLD1-0005GA-Cj for qemu-devel@nongnu.org; Sun, 08 Mar 2009 11:46:35 -0400 Received: by fg-out-1718.google.com with SMTP id e21so715237fga.8 for ; Sun, 08 Mar 2009 08:46:33 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <49B3E5F3.3000209@web.de> References: <49B3D904.2090202@web.de> <761ea48b0903080803l7e481a96p4511076b7f69305a@mail.gmail.com> <49B3E5F3.3000209@web.de> Date: Sun, 8 Mar 2009 16:46:33 +0100 Message-ID: <761ea48b0903080846p6a0c0bfcoc96dd2f37490dde0@mail.gmail.com> Subject: Re: [Qemu-devel] Re: dyngen-exec.h cleanup From: Laurent Desnogues Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On Sun, Mar 8, 2009 at 4:36 PM, Jan Kiszka wrote: > Laurent Desnogues wrote: >> On Sun, Mar 8, 2009 at 3:41 PM, Jan Kiszka wrote: >>> Also, some discussion on this list suggested that it's more efficient to >>> look into converting the remaining AREGS to TCG and finally do the >>> ultimative "rm dyngen-exec.h". Don't you want to spend some time on this >>> already? >> >> This requires modifying ARM translator which is the last one to use >> AREGn with n>0. And don't all targets use AREG0 as a pointer to the >> CPU state? > > Yes, but wasn't it you who suggested that all those users should be > converted over to the tcg_global_reg API? Yes, and I did the work for ARM. However when considering the removal of AREG0, and after looking at generated code, I came to the perhaps premature conclusion that removing it would not bring me any speedup (at least for a not so register starved target as x86_64). > There is surely some work to do, and that probably across all archs. But > the sooner we should start. dyngen-exec.h is a constant source of pain > when you try to introduce new headers or refactor existing ones. Well dyngen-exec.h is long gone in my sources even though AREG0 is still used. I would have to backtrack my changes to see how I arrived to that, but for sure the first thing to do is to remove cpu_T from ARM target. Laurent