[Qemu-devel] [PATCH] Fix tcg after commit 6800

[Qemu-devel] [PATCH] Fix tcg after commit 6800

[Laurent Desnogues]

[-- Attachment #1: Type: text/plain, Size: 185 bytes --]

Hello,

the introduction of TCGV_EQUAL and not op is slightly broken.
The definition of DEBUG_TCGV shows that.


Laurent

Signed-off-by: Laurent Desnogues <laurent.desnogues@gmail.com>

[-- Attachment #2: tcg-6800.patch --]
[-- Type: text/x-patch, Size: 1207 bytes --]

Index: tcg/tcg-op.h
===================================================================
--- tcg/tcg-op.h	(revision 6801)
+++ tcg/tcg-op.h	(working copy)
@@ -1435,7 +1435,7 @@
 static inline void tcg_gen_not_i64(TCGv_i64 ret, TCGv_i64 arg)
 {
 #ifdef TCG_TARGET_HAS_not_i64
-    tcg_gen_op2_i32(INDEX_op_not_i64, ret, arg);
+    tcg_gen_op2_i64(INDEX_op_not_i64, ret, arg);
 #else
     tcg_gen_xori_i64(ret, arg, -1);
 #endif
Index: tcg/tcg.h
===================================================================
--- tcg/tcg.h	(revision 6801)
+++ tcg/tcg.h	(working copy)
@@ -153,8 +153,6 @@
 #define MAKE_TCGV_I64(x) (x)
 #define GET_TCGV_I32(t) (t)
 #define GET_TCGV_I64(t) (t)
-#define TCGV_EQUAL_I32(a, b) (GET_TCGV_I32(a) == GET_TCGV_I32(b))
-#define TCGV_EQUAL_I64(a, b) (GET_TCGV_I64(a) == GET_TCGV_I64(b))
 
 #if TCG_TARGET_REG_BITS == 32
 #define TCGV_LOW(t) (t)
@@ -163,6 +161,9 @@
 
 #endif /* DEBUG_TCGV */
 
+#define TCGV_EQUAL_I32(a, b) (GET_TCGV_I32(a) == GET_TCGV_I32(b))
+#define TCGV_EQUAL_I64(a, b) (GET_TCGV_I64(a) == GET_TCGV_I64(b))
+
 /* Dummy definition to avoid compiler warnings.  */
 #define TCGV_UNUSED_I32(x) x = MAKE_TCGV_I32(-1)
 #define TCGV_UNUSED_I64(x) x = MAKE_TCGV_I64(-1)

Re: [Qemu-devel] [PATCH] Fix tcg after commit 6800

[Aurelien Jarno]

On Tue, Mar 10, 2009 at 10:43:02AM +0100, Laurent Desnogues wrote:
> Hello,
> 
> the introduction of TCGV_EQUAL and not op is slightly broken.
> The definition of DEBUG_TCGV shows that.
> 
> 
> Laurent
> 
> Signed-off-by: Laurent Desnogues <laurent.desnogues@gmail.com>

Thanks, applied.


-- 
Aurelien Jarno	                        GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net