From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LwBSo-0001FU-BC for qemu-devel@nongnu.org; Tue, 21 Apr 2009 04:36:22 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LwBSn-0001Ey-N1 for qemu-devel@nongnu.org; Tue, 21 Apr 2009 04:36:21 -0400 Received: from [199.232.76.173] (port=56357 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LwBSn-0001En-3Y for qemu-devel@nongnu.org; Tue, 21 Apr 2009 04:36:21 -0400 Received: from fg-out-1718.google.com ([72.14.220.159]:2436) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LwBSm-0004eJ-NA for qemu-devel@nongnu.org; Tue, 21 Apr 2009 04:36:20 -0400 Received: by fg-out-1718.google.com with SMTP id e21so770398fga.8 for ; Tue, 21 Apr 2009 01:36:19 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <878wlufm8s.fsf@lechat.rtp-net.org> References: <878wlufm8s.fsf@lechat.rtp-net.org> Date: Tue, 21 Apr 2009 10:36:19 +0200 Message-ID: <761ea48b0904210136p432bb31dj76ecd09e59b27228@mail.gmail.com> Subject: Re: [Qemu-devel] [PATCH] Fix utimensat (aka unbreak cp -a) From: Laurent Desnogues Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Arnaud Patard Cc: qemu-devel@nongnu.org On Tue, Apr 21, 2009 at 10:24 AM, Arnaud Patard wrote: > > > Don't use the glibc function for utimensat because glibc returns -EINVAL > if the path is null which is a different behaviour with the syscall. > path can be null because internally the glibc is using utimensat with > path null (for instance, see __futimes in > sysdeps/unix/sysv/linux/futimes.c in glibc tree). > > > Signed-off-by: Arnaud Patard Acked-by: Laurent Desnogues