From: Laurent Desnogues <laurent.desnogues@gmail.com>
To: Paul Brook <paul@codesourcery.com>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: [Qemu-devel] Re: [Qemu-commits] [COMMIT b864a57] Fixe ARM NEON vrshl.
Date: Sun, 10 May 2009 00:35:37 +0200 [thread overview]
Message-ID: <761ea48b0905091535l75076d7eg4d607ca7a494385@mail.gmail.com> (raw)
In-Reply-To: <200905092213.n49MDPEP016120@d03av03.boulder.ibm.com>
On Sun, May 10, 2009 at 12:14 AM, Anthony Liguori <aliguori@us.ibm.com> wrote:
> From: Paul Brook <paul@codesourcery.com>
>
> Signed-off-by: Paul Brook <paul@codesourcery.com>
>
> diff --git a/target-arm/neon_helper.c b/target-arm/neon_helper.c
> index 4ee5658..35fbaf5 100644
> --- a/target-arm/neon_helper.c
> +++ b/target-arm/neon_helper.c
> @@ -456,11 +456,11 @@ uint64_t HELPER(neon_shl_s64)(uint64_t valop, uint64_t shiftop)
> if (tmp >= sizeof(src1) * 8) { \
> dest = 0; \
> } else if (tmp < -sizeof(src1) * 8) { \
> - dest >>= sizeof(src1) * 8 - 1; \
> + dest = src1 >> (sizeof(src1) * 8 - 1); \
> } else if (tmp == -sizeof(src1) * 8) { \
> dest = src1 >> (tmp - 1); \
Isn't that a right shift by a negative amount?
Laurent
> dest++; \
> - src2 >>= 1; \
> + dest >>= 1; \
> } else if (tmp < 0) { \
> dest = (src1 + (1 << (-1 - tmp))) >> -tmp; \
> } else { \
parent reply other threads:[~2009-05-09 22:35 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <200905092213.n49MDPEP016120@d03av03.boulder.ibm.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=761ea48b0905091535l75076d7eg4d607ca7a494385@mail.gmail.com \
--to=laurent.desnogues@gmail.com \
--cc=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).