* [Qemu-devel] Re: [Qemu-commits] [COMMIT b864a57] Fixe ARM NEON vrshl.
[not found] <200905092213.n49MDPEP016120@d03av03.boulder.ibm.com>
@ 2009-05-09 22:35 ` Laurent Desnogues
0 siblings, 0 replies; only message in thread
From: Laurent Desnogues @ 2009-05-09 22:35 UTC (permalink / raw)
To: Paul Brook; +Cc: qemu-devel@nongnu.org
On Sun, May 10, 2009 at 12:14 AM, Anthony Liguori <aliguori@us.ibm.com> wrote:
> From: Paul Brook <paul@codesourcery.com>
>
> Signed-off-by: Paul Brook <paul@codesourcery.com>
>
> diff --git a/target-arm/neon_helper.c b/target-arm/neon_helper.c
> index 4ee5658..35fbaf5 100644
> --- a/target-arm/neon_helper.c
> +++ b/target-arm/neon_helper.c
> @@ -456,11 +456,11 @@ uint64_t HELPER(neon_shl_s64)(uint64_t valop, uint64_t shiftop)
> if (tmp >= sizeof(src1) * 8) { \
> dest = 0; \
> } else if (tmp < -sizeof(src1) * 8) { \
> - dest >>= sizeof(src1) * 8 - 1; \
> + dest = src1 >> (sizeof(src1) * 8 - 1); \
> } else if (tmp == -sizeof(src1) * 8) { \
> dest = src1 >> (tmp - 1); \
Isn't that a right shift by a negative amount?
Laurent
> dest++; \
> - src2 >>= 1; \
> + dest >>= 1; \
> } else if (tmp < 0) { \
> dest = (src1 + (1 << (-1 - tmp))) >> -tmp; \
> } else { \
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2009-05-09 22:35 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <200905092213.n49MDPEP016120@d03av03.boulder.ibm.com>
2009-05-09 22:35 ` [Qemu-devel] Re: [Qemu-commits] [COMMIT b864a57] Fixe ARM NEON vrshl Laurent Desnogues
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).