From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1M4CmF-0001Os-JM
	for qemu-devel@nongnu.org; Wed, 13 May 2009 07:37:35 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1M4CmD-0001Oa-VE
	for qemu-devel@nongnu.org; Wed, 13 May 2009 07:37:34 -0400
Received: from [199.232.76.173] (port=48875 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1M4CmD-0001OX-QP
	for qemu-devel@nongnu.org; Wed, 13 May 2009 07:37:33 -0400
Received: from fg-out-1718.google.com ([72.14.220.153]:37841)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <laurent.desnogues@gmail.com>) id 1M4CmD-0006Gz-F1
	for qemu-devel@nongnu.org; Wed, 13 May 2009 07:37:33 -0400
Received: by fg-out-1718.google.com with SMTP id e21so191255fga.8
	for <qemu-devel@nongnu.org>; Wed, 13 May 2009 04:37:32 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <Pine.LNX.4.64.0905131525450.2807@linmac.oyster.ru>
References: <1242156419-23821-1-git-send-email-froydnj@codesourcery.com>
	<Pine.LNX.4.64.0905130305530.11267@linmac.oyster.ru>
	<20090513021544.GW23911@codesourcery.com>
	<Pine.LNX.4.64.0905131525450.2807@linmac.oyster.ru>
Date: Wed, 13 May 2009 13:37:32 +0200
Message-ID: <761ea48b0905130437r64ded5d7y88ea66e513680c3a@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH 0/3] linux-user: add ppc signal handling, v2
From: Laurent Desnogues <laurent.desnogues@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: malc <av1474@comtv.ru>
Cc: qemu-devel@nongnu.org, Nathan Froyd <froydnj@codesourcery.com>

On Wed, May 13, 2009 at 1:27 PM, malc <av1474@comtv.ru> wrote:
>
> Done. BTW. here's another:
>
> target-ppc/op_helper.c:1977: warning: comparison is always false due to
> limited range of data type
>
> This one is probably harmless, but still.. [The code is due to Aurelien
> this time around though]

Are you sure?  I thought it was part of a patch sent by Nathan.
Anyway that indeed is harmless since it's due to this test (after
macro expansion):

        if (0 && x < 0) {

BTW gcc 4.3.2 doesn't complain about it.


Laurent