qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Laurent Desnogues <laurent.desnogues@gmail.com>
To: "Timo Töyry" <ttoyry@cs.hut.fi>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] Instruction counting instrumentation for ARM + initial patch
Date: Wed, 20 May 2009 14:16:12 +0200	[thread overview]
Message-ID: <761ea48b0905200516g47713089g5d0b06f6f94bcd1a@mail.gmail.com> (raw)
In-Reply-To: <200905201148.43631.paul@codesourcery.com>

On Wed, May 20, 2009 at 12:48 PM, Paul Brook <paul@codesourcery.com> wrote:
> On Tuesday 19 May 2009, Timo Töyry wrote:
>> Hi,
>>
>> The attached patch implements instruction counting instrumentation for
>> ARM usermode linux. Currently the patch is a working draft but we
>> intend to clean it up for possible inclusion. We'd appreciate any
>> comments. Below is a more detailed description.
>
> Ewww. This looks pretty much impossible to maintain.
> If you really want to do this I recommend dumping an execution trace, and
> having a third party utility do the counting after the fact.

My advice would be similar to Paul's:  for my instruction counter,
instead of counting instructions, I count translation blocks.  I can
either output a TB trace (which can be huge, but useful to do
trace analysis) or an execution count for each TB.  As a postpass
you can do whatever you want.  The benefits, on top of being easier
to maintain, are that it's more flexible, it has a very small impact on
QEMU execution time, and it can be trivially ported to any front end.
The problem is to play nicely with TB flushes :-)

HTH,

Laurent

  reply	other threads:[~2009-05-20 12:16 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-19 14:59 [Qemu-devel] Instruction counting instrumentation for ARM + initial patch Timo Töyry
2009-05-20 10:48 ` Paul Brook
2009-05-20 12:16   ` Laurent Desnogues [this message]
2009-05-20 20:35     ` Vince Weaver
2009-05-23 13:23       ` Laurent Desnogues
2009-05-25 15:04         ` Sami Kiminki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=761ea48b0905200516g47713089g5d0b06f6f94bcd1a@mail.gmail.com \
    --to=laurent.desnogues@gmail.com \
    --cc=qemu-devel@nongnu.org \
    --cc=ttoyry@cs.hut.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).