From: Laurent Desnogues <laurent.desnogues@gmail.com>
To: Filip Navara <filip.navara@gmail.com>
Cc: qemu-devel@nongnu.org, Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-devel] [PATCH] RFC: TCG constant propagation.
Date: Thu, 23 Jul 2009 11:25:34 +0200 [thread overview]
Message-ID: <761ea48b0907230225g77d7d0e6q6e1fd8af302ed795@mail.gmail.com> (raw)
In-Reply-To: <5b31733c0907230208o7374ad68uf6e4438a5c5a41d5@mail.gmail.com>
On Thu, Jul 23, 2009 at 11:08 AM, Filip Navara<filip.navara@gmail.com> wrote:
> Also it looks that the actual code size is worse for TCG ARM target
> with this optimization. To mitigate it I propose the other attached
> patch which uses the barrel shifter for more optimal generation of the
> "movi" operation. I can't test it, so any help is welcome.
This is wrong for two reasons:
- this is a rotation, you only check for shifts
- the rotation amount is multiplied by 2 before being applied to the
8-bit immediate field.
Laurent
next prev parent reply other threads:[~2009-07-23 9:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-21 14:37 [Qemu-devel] [PATCH] RFC: TCG constant propagation Filip Navara
2009-07-23 9:08 ` Filip Navara
2009-07-23 9:25 ` Laurent Desnogues [this message]
2009-07-23 9:30 ` Paul Brook
2009-07-23 9:49 ` Filip Navara
2009-07-23 20:10 ` Stuart Brady
2009-07-23 20:28 ` Filip Navara
2009-07-23 22:02 ` Daniel Jacobowitz
2009-08-05 8:13 ` Pablo Virolainen
2009-08-05 8:48 ` Filip Navara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=761ea48b0907230225g77d7d0e6q6e1fd8af302ed795@mail.gmail.com \
--to=laurent.desnogues@gmail.com \
--cc=filip.navara@gmail.com \
--cc=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).