qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Laurent Desnogues <laurent.desnogues@gmail.com>
To: Juan Quintela <quintela@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 6/7] Add -Wold-style-declaration -Wold-style-definition to QEMU_CFLAGS
Date: Wed, 23 Sep 2009 10:48:19 +0200	[thread overview]
Message-ID: <761ea48b0909230148l46b757dcwcc9d1c0d5aec9a8@mail.gmail.com> (raw)
In-Reply-To: <83add4094da4dd3ddd50d849623f658e93e482c0.1253661009.git.quintela@redhat.com>

On Wed, Sep 23, 2009 at 1:19 AM, Juan Quintela <quintela@redhat.com> wrote:
> ANSI c89 has been with us for a while.
>
> Signed-off-by: Juan Quintela <quintela@redhat.com>
> ---
>  configure |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/configure b/configure
> index 62dccd2..81b9ba8 100755
> --- a/configure
> +++ b/configure
> @@ -1648,6 +1648,7 @@ if test "$debug" = "no" ; then
>  fi
>  QEMU_CFLAGS="-Wall -Wundef -Wendif-labels -Wwrite-strings -Wmissing-prototypes $QEMU_CFLAGS"
>  QEMU_CFLAGS="-Wstrict-prototypes -Wredundant-decls $QEMU_CFLAGS"
> +QEMU_CFLAGS="-Wold-style-declaration -Wold-style-definition $QEMU_CFLAGS"

Some older versions of gcc don't handle -Wold-style-declaration.
For instance gcc 4.1.2.


Laurent

>  QEMU_CFLAGS="-D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE $QEMU_CFLAGS"
>  QEMU_CFLAGS="-U_FORTIFY_SOURCE $QEMU_CFLAGS"
>  QEMU_CFLAGS="-I. -I\$(SRC_PATH) -MMD -MP -MT \$@ $QEMU_CFLAGS"
> --
> 1.6.2.5
>
>
>
>

  reply	other threads:[~2009-09-23  8:48 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-22 23:18 [Qemu-devel] [PATCH 0/7] Remove pre ANSI c89 code Juan Quintela
2009-09-22 23:18 ` [Qemu-devel] [PATCH 1/7] Use proper typedef syntax Juan Quintela
2009-09-23  0:24   ` [Qemu-devel] " Måns Rullgård
2009-09-22 23:19 ` [Qemu-devel] [PATCH 2/7] static and inline should came before the type of the functions Juan Quintela
2009-09-22 23:19 ` [Qemu-devel] [PATCH 3/7] Bring two last users of K&R definitions to ANSI c89 Juan Quintela
2009-09-22 23:19 ` [Qemu-devel] [PATCH 4/7] gcc wants 1st static and then const Juan Quintela
2009-09-22 23:19 ` [Qemu-devel] [PATCH 5/7] __thread should be before real type Juan Quintela
2009-09-22 23:19 ` [Qemu-devel] [PATCH 6/7] Add -Wold-style-declaration -Wold-style-definition to QEMU_CFLAGS Juan Quintela
2009-09-23  8:48   ` Laurent Desnogues [this message]
2009-09-23 16:09     ` Markus Armbruster
2009-09-23 17:16       ` Blue Swirl
2009-09-29 23:15         ` [Qemu-devel] " Juan Quintela
2009-09-22 23:19 ` [Qemu-devel] [PATCH 7/7] Remove PARAMS() macro Juan Quintela
2009-09-23 16:11 ` [Qemu-devel] [PATCH 0/7] Remove pre ANSI c89 code Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=761ea48b0909230148l46b757dcwcc9d1c0d5aec9a8@mail.gmail.com \
    --to=laurent.desnogues@gmail.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).