From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MqNWW-0007gv-FG
	for qemu-devel@nongnu.org; Wed, 23 Sep 2009 04:48:28 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MqNWR-0007gU-0E
	for qemu-devel@nongnu.org; Wed, 23 Sep 2009 04:48:27 -0400
Received: from [199.232.76.173] (port=32993 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MqNWQ-0007gQ-N3
	for qemu-devel@nongnu.org; Wed, 23 Sep 2009 04:48:22 -0400
Received: from mail-fx0-f214.google.com ([209.85.220.214]:39800)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <laurent.desnogues@gmail.com>) id 1MqNWP-0001wF-8t
	for qemu-devel@nongnu.org; Wed, 23 Sep 2009 04:48:22 -0400
Received: by fxm10 with SMTP id 10so405112fxm.8
	for <qemu-devel@nongnu.org>; Wed, 23 Sep 2009 01:48:19 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <83add4094da4dd3ddd50d849623f658e93e482c0.1253661009.git.quintela@redhat.com>
References: <cover.1253661009.git.quintela@redhat.com>
	<83add4094da4dd3ddd50d849623f658e93e482c0.1253661009.git.quintela@redhat.com>
Date: Wed, 23 Sep 2009 10:48:19 +0200
Message-ID: <761ea48b0909230148l46b757dcwcc9d1c0d5aec9a8@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH 6/7] Add -Wold-style-declaration
	-Wold-style-definition to QEMU_CFLAGS
From: Laurent Desnogues <laurent.desnogues@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Juan Quintela <quintela@redhat.com>
Cc: qemu-devel@nongnu.org

On Wed, Sep 23, 2009 at 1:19 AM, Juan Quintela <quintela@redhat.com> wrote:
> ANSI c89 has been with us for a while.
>
> Signed-off-by: Juan Quintela <quintela@redhat.com>
> ---
> =A0configure | =A0 =A01 +
> =A01 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/configure b/configure
> index 62dccd2..81b9ba8 100755
> --- a/configure
> +++ b/configure
> @@ -1648,6 +1648,7 @@ if test "$debug" =3D "no" ; then
> =A0fi
> =A0QEMU_CFLAGS=3D"-Wall -Wundef -Wendif-labels -Wwrite-strings -Wmissing-=
prototypes $QEMU_CFLAGS"
> =A0QEMU_CFLAGS=3D"-Wstrict-prototypes -Wredundant-decls $QEMU_CFLAGS"
> +QEMU_CFLAGS=3D"-Wold-style-declaration -Wold-style-definition $QEMU_CFLA=
GS"

Some older versions of gcc don't handle -Wold-style-declaration.
For instance gcc 4.1.2.


Laurent

> =A0QEMU_CFLAGS=3D"-D_GNU_SOURCE -D_FILE_OFFSET_BITS=3D64 -D_LARGEFILE_SOU=
RCE $QEMU_CFLAGS"
> =A0QEMU_CFLAGS=3D"-U_FORTIFY_SOURCE $QEMU_CFLAGS"
> =A0QEMU_CFLAGS=3D"-I. -I\$(SRC_PATH) -MMD -MP -MT \$@ $QEMU_CFLAGS"
> --
> 1.6.2.5
>
>
>
>