qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Laurent Desnogues <laurent.desnogues@gmail.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] tcg_abort()
Date: Sat, 26 Sep 2009 00:48:57 +0200	[thread overview]
Message-ID: <761ea48b0909251548l46efb05v49594cb4d2f72ee2@mail.gmail.com> (raw)
In-Reply-To: <761ea48b0909160916y21771671g9399ddf9983ac5c0@mail.gmail.com>

On Wed, Sep 16, 2009 at 6:16 PM, Laurent Desnogues
<laurent.desnogues@gmail.com> wrote:
> On Wed, Sep 16, 2009 at 5:46 PM, Gary Thomas <gary@mlbassoc.com> wrote:
> [...]
>>
>> /qemu-git-2009_09_16/tcg/arm/tcg-target.c:773: tcg fatal error
>>
>>>   - how to reproduce the issue
>>
>> This one's harder - I'm running an x86 gnome application on an ARM
>> system.  I'm not sure exactly what it was doing when the abort happened.
>>
>> Questions:
>>  * The function in tcp-target.c seems complete, but it has
>>      #if 1
>>        tcg_abort();
>>      #endif
>>    which implies it's not complete or maybe just untested?
>>  * How can I gather more information about what was going on
>>    at the time to aid in fixing this?
>
> Your problem is probably due to generated code being too far from
> the helper functions (the helper functions can be thought of as a
> library).
>
> Could please try to replace the tcg_abort() on line 773 with these
> two lines?
>
>        tcg_out_movi32(s, cond, TCG_REG_R8, val);
>        tcg_out32(s, (cond << 28) | 0x012fff30 | TCG_REG_R8); /* blx r8 */
>
> I didn't test it, so you'll be my guinea pig :-)

Turned out this was wrong, it should have been:

        tcg_out_movi32(s, cond, TCG_REG_R8, addr);
        tcg_out32(s, (cond << 28) | 0x012fff30 | TCG_REG_R8); /* blx r8 */


Laurent

  parent reply	other threads:[~2009-09-25 22:49 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-16 15:19 [Qemu-devel] tcg_abort() Gary Thomas
2009-09-16 15:31 ` Laurent Desnogues
2009-09-16 15:46   ` Gary Thomas
2009-09-16 16:16     ` Laurent Desnogues
2009-09-16 18:22       ` Gary Thomas
2009-09-16 18:24         ` Laurent Desnogues
2009-09-25 22:48       ` Laurent Desnogues [this message]
2009-09-28 11:15         ` Paul Brook
2009-09-28 11:24           ` Laurent Desnogues

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=761ea48b0909251548l46efb05v49594cb4d2f72ee2@mail.gmail.com \
    --to=laurent.desnogues@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).