From: Laurent Desnogues <laurent.desnogues@gmail.com>
To: Paul Brook <paul@codesourcery.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] tcg_abort()
Date: Mon, 28 Sep 2009 13:24:55 +0200 [thread overview]
Message-ID: <761ea48b0909280424r4f5d5bf6tc353196b88ccca96@mail.gmail.com> (raw)
In-Reply-To: <200909281215.40687.paul@codesourcery.com>
On Mon, Sep 28, 2009 at 1:15 PM, Paul Brook <paul@codesourcery.com> wrote:
>> > Could please try to replace the tcg_abort() on line 773 with these
>> > two lines?
>>
>> Turned out this was wrong, it should have been:
>>
>> tcg_out_movi32(s, cond, TCG_REG_R8, addr);
>> tcg_out32(s, (cond << 28) | 0x012fff30 | TCG_REG_R8); /* blx r8 */
>
> You can not assume blx is available.
Which is why this wasn't proposed as a patch :-)
Laurent
prev parent reply other threads:[~2009-09-28 11:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-16 15:19 [Qemu-devel] tcg_abort() Gary Thomas
2009-09-16 15:31 ` Laurent Desnogues
2009-09-16 15:46 ` Gary Thomas
2009-09-16 16:16 ` Laurent Desnogues
2009-09-16 18:22 ` Gary Thomas
2009-09-16 18:24 ` Laurent Desnogues
2009-09-25 22:48 ` Laurent Desnogues
2009-09-28 11:15 ` Paul Brook
2009-09-28 11:24 ` Laurent Desnogues [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=761ea48b0909280424r4f5d5bf6tc353196b88ccca96@mail.gmail.com \
--to=laurent.desnogues@gmail.com \
--cc=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).