[Qemu-devel] Some comments about recent modifications to target-i386/cpu.h

[Qemu-devel] Some comments about recent modifications to target-i386/cpu.h

[Laurent Desnogues]

Hello,

some recent commits

67b8f419575b9e4521f0fa59b7a0faee401502ca
eb831623114b6b74172629f9f6db7b7eb979d90b
cdc0c58fa9d86559f6811426eee16b0464dfcd93

changed the following:

1. adding some _vmstate fields in the middle of other runtime flags;
   since these only belong to the save/restore facility could they
   please be moved towards the end of the structure so that hosts
   that have addressing modes with limited offsets aren't impacted?

2. changing fpus and fpuc to uint16_t;
   this will prevent the use of these fields as global temporaries.

Thanks,

Laurent

[Qemu-devel] Re: Some comments about recent modifications to target-i386/cpu.h

[Laurent Desnogues]

On Mon, Oct 5, 2009 at 6:43 PM, Juan Quintela <quintela@trasno.org> wrote:
[...]
>> 2. changing fpus and fpuc to uint16_t;
>>    this will prevent the use of these fields as global temporaries.
>
> humm, and where/how should I have know this?
> I found that everything that fields where used, they were used as
> uint16_t, obviously I was wrong.

That wasn't meant to be a criticism, just a reminder that some
things which might be good for para-virtualization are not
necessarily good for TCG :-)

But I agree fpus, fpuc can be kept as uint16_t until someone
decide to make TCG know about floating-point.


Laurent