From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MvB2o-00083I-BL for qemu-devel@nongnu.org; Tue, 06 Oct 2009 10:29:38 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MvB2n-00082S-IQ for qemu-devel@nongnu.org; Tue, 06 Oct 2009 10:29:37 -0400 Received: from [199.232.76.173] (port=36451 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MvB2n-00082E-AD for qemu-devel@nongnu.org; Tue, 06 Oct 2009 10:29:37 -0400 Received: from fg-out-1718.google.com ([72.14.220.154]:27938) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MvB2m-0000if-SF for qemu-devel@nongnu.org; Tue, 06 Oct 2009 10:29:37 -0400 Received: by fg-out-1718.google.com with SMTP id e21so693482fga.10 for ; Tue, 06 Oct 2009 07:29:36 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20091005215606.GA22831@volta.aurel32.net> References: <761ea48b0910050818g6d3e9974h51a2d1d11fde5ee6@mail.gmail.com> <20091005215606.GA22831@volta.aurel32.net> Date: Tue, 6 Oct 2009 16:29:35 +0200 Message-ID: <761ea48b0910060729r4ec322f5jaebc6ee128899aaa@mail.gmail.com> Subject: Re: [Qemu-devel] [PATCH] i386 target: fix ARPL From: Laurent Desnogues Content-Type: multipart/mixed; boundary=00163600d59d3fc7df0475450f13 List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org --00163600d59d3fc7df0475450f13 Content-Type: text/plain; charset=ISO-8859-1 On Mon, Oct 5, 2009 at 11:56 PM, Aurelien Jarno wrote: [...] > This looks indeed correct. I wonder however if it would be better to do > the tcg_temp_local_new() / tcg_temp_free() in the if (mod != 3) path > only. I'm not sure it will make any difference (arpl is probably not used extensively). Anywyay here is an updated patch. Laurent Signed-off-by: Laurent Desnogues --00163600d59d3fc7df0475450f13 Content-Type: text/x-diff; charset=US-ASCII; name="i386-arpl-v2.patch" Content-Disposition: attachment; filename="i386-arpl-v2.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_g0gqxfze0 ZGlmZiAtLWdpdCBhL3RhcmdldC1pMzg2L3RyYW5zbGF0ZS5jIGIvdGFyZ2V0LWkzODYvdHJhbnNs YXRlLmMKaW5kZXggZTNjYjQ5Zi4uMjUxMTk0MyAxMDA2NDQKLS0tIGEvdGFyZ2V0LWkzODYvdHJh bnNsYXRlLmMKKysrIGIvdGFyZ2V0LWkzODYvdHJhbnNsYXRlLmMKQEAgLTczMDUsNyArNzMwNSw3 IEBAIHN0YXRpYyB0YXJnZXRfdWxvbmcgZGlzYXNfaW5zbihEaXNhc0NvbnRleHQgKnMsIHRhcmdl dF91bG9uZyBwY19zdGFydCkKICNlbmRpZgogICAgICAgICB7CiAgICAgICAgICAgICBpbnQgbGFi ZWwxOwotICAgICAgICAgICAgVENHdiB0MCwgdDEsIHQyOworICAgICAgICAgICAgVENHdiB0MCwg dDEsIHQyLCBhMDsKIAogICAgICAgICAgICAgaWYgKCFzLT5wZSB8fCBzLT52bTg2KQogICAgICAg ICAgICAgICAgIGdvdG8gaWxsZWdhbF9vcDsKQEAgLTczMjAsOCArNzMyMCwxMSBAQCBzdGF0aWMg dGFyZ2V0X3Vsb25nIGRpc2FzX2luc24oRGlzYXNDb250ZXh0ICpzLCB0YXJnZXRfdWxvbmcgcGNf c3RhcnQpCiAgICAgICAgICAgICBpZiAobW9kICE9IDMpIHsKICAgICAgICAgICAgICAgICBnZW5f bGVhX21vZHJtKHMsIG1vZHJtLCAmcmVnX2FkZHIsICZvZmZzZXRfYWRkcik7CiAgICAgICAgICAg ICAgICAgZ2VuX29wX2xkX3Yob3QgKyBzLT5tZW1faW5kZXgsIHQwLCBjcHVfQTApOworICAgICAg ICAgICAgICAgIGEwID0gdGNnX3RlbXBfbG9jYWxfbmV3KCk7CisgICAgICAgICAgICAgICAgdGNn X2dlbl9tb3ZfdGwoYTAsIGNwdV9BMCk7CiAgICAgICAgICAgICB9IGVsc2UgewogICAgICAgICAg ICAgICAgIGdlbl9vcF9tb3Zfdl9yZWcob3QsIHQwLCBybSk7CisgICAgICAgICAgICAgICAgVENH Vl9VTlVTRUQoYTApOwogICAgICAgICAgICAgfQogICAgICAgICAgICAgZ2VuX29wX21vdl92X3Jl ZyhvdCwgdDEsIHJlZyk7CiAgICAgICAgICAgICB0Y2dfZ2VuX2FuZGlfdGwoY3B1X3RtcDAsIHQw LCAzKTsKQEAgLTczMzQsOCArNzMzNyw5IEBAIHN0YXRpYyB0YXJnZXRfdWxvbmcgZGlzYXNfaW5z bihEaXNhc0NvbnRleHQgKnMsIHRhcmdldF91bG9uZyBwY19zdGFydCkKICAgICAgICAgICAgIHRj Z19nZW5fbW92aV90bCh0MiwgQ0NfWik7CiAgICAgICAgICAgICBnZW5fc2V0X2xhYmVsKGxhYmVs MSk7CiAgICAgICAgICAgICBpZiAobW9kICE9IDMpIHsKLSAgICAgICAgICAgICAgICBnZW5fb3Bf c3RfdihvdCArIHMtPm1lbV9pbmRleCwgdDAsIGNwdV9BMCk7Ci0gICAgICAgICAgICB9IGVsc2Ug eworICAgICAgICAgICAgICAgIGdlbl9vcF9zdF92KG90ICsgcy0+bWVtX2luZGV4LCB0MCwgYTAp OworICAgICAgICAgICAgICAgIHRjZ190ZW1wX2ZyZWUoYTApOworICAgICAgICAgICB9IGVsc2Ug ewogICAgICAgICAgICAgICAgIGdlbl9vcF9tb3ZfcmVnX3Yob3QsIHJtLCB0MCk7CiAgICAgICAg ICAgICB9CiAgICAgICAgICAgICBpZiAocy0+Y2Nfb3AgIT0gQ0NfT1BfRFlOQU1JQykK --00163600d59d3fc7df0475450f13--