From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MzWlf-00024E-3w
	for qemu-devel@nongnu.org; Sun, 18 Oct 2009 10:29:55 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MzWle-000240-Mj
	for qemu-devel@nongnu.org; Sun, 18 Oct 2009 10:29:54 -0400
Received: from [199.232.76.173] (port=48587 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MzWle-00023x-IE
	for qemu-devel@nongnu.org; Sun, 18 Oct 2009 10:29:54 -0400
Received: from fg-out-1718.google.com ([72.14.220.158]:42738)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <laurent.desnogues@gmail.com>) id 1MzWle-0008Nq-4s
	for qemu-devel@nongnu.org; Sun, 18 Oct 2009 10:29:54 -0400
Received: by fg-out-1718.google.com with SMTP id 16so137944fgg.10
	for <qemu-devel@nongnu.org>; Sun, 18 Oct 2009 07:29:52 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <20091015215157.GD7071@volta.aurel32.net>
References: <20091015215157.GD7071@volta.aurel32.net>
Date: Sun, 18 Oct 2009 16:29:52 +0200
Message-ID: <761ea48b0910180729v7f277b02n641715865688f77@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH] target-arm: log instructions start in TCG
	code
From: Laurent Desnogues <laurent.desnogues@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Aurelien Jarno <aurelien@aurel32.net>
Cc: qemu-devel@nongnu.org

On Thu, Oct 15, 2009 at 11:51 PM, Aurelien Jarno <aurelien@aurel32.net> wro=
te:
> Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
> ---
> =A0target-arm/translate.c | =A0 =A04 ++++
> =A01 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/target-arm/translate.c b/target-arm/translate.c
> index 0c10ac2..bb0f8ef 100644
> --- a/target-arm/translate.c
> +++ b/target-arm/translate.c
> @@ -8805,6 +8805,10 @@ static inline void gen_intermediate_code_internal(=
CPUState *env,
> =A0 =A0 =A0 =A0 if (num_insns + 1 =3D=3D max_insns && (tb->cflags & CF_LA=
ST_IO))
> =A0 =A0 =A0 =A0 =A0 =A0 gen_io_start();
>
> + =A0 =A0 =A0 =A0if (unlikely(qemu_loglevel_mask(CPU_LOG_TB_OP))) {
> + =A0 =A0 =A0 =A0 =A0 =A0tcg_gen_debug_insn_start(dc->pc);
> + =A0 =A0 =A0 =A0}
> +
> =A0 =A0 =A0 =A0 if (env->thumb) {
> =A0 =A0 =A0 =A0 =A0 =A0 disas_thumb_insn(env, dc);
> =A0 =A0 =A0 =A0 =A0 =A0 if (dc->condexec_mask) {
> --
> 1.6.1.3

Shouldn't you dump the TCG debug instruction before the
check for gen_io_start?


Laurent