* [Qemu-devel] [PATCH] target-arm: log instructions start in TCG code
@ 2009-10-15 21:51 Aurelien Jarno
2009-10-18 14:29 ` Laurent Desnogues
0 siblings, 1 reply; 3+ messages in thread
From: Aurelien Jarno @ 2009-10-15 21:51 UTC (permalink / raw)
To: qemu-devel
Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
---
target-arm/translate.c | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/target-arm/translate.c b/target-arm/translate.c
index 0c10ac2..bb0f8ef 100644
--- a/target-arm/translate.c
+++ b/target-arm/translate.c
@@ -8805,6 +8805,10 @@ static inline void gen_intermediate_code_internal(CPUState *env,
if (num_insns + 1 == max_insns && (tb->cflags & CF_LAST_IO))
gen_io_start();
+ if (unlikely(qemu_loglevel_mask(CPU_LOG_TB_OP))) {
+ tcg_gen_debug_insn_start(dc->pc);
+ }
+
if (env->thumb) {
disas_thumb_insn(env, dc);
if (dc->condexec_mask) {
--
1.6.1.3
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] target-arm: log instructions start in TCG code
2009-10-15 21:51 [Qemu-devel] [PATCH] target-arm: log instructions start in TCG code Aurelien Jarno
@ 2009-10-18 14:29 ` Laurent Desnogues
2009-10-22 20:55 ` Aurelien Jarno
0 siblings, 1 reply; 3+ messages in thread
From: Laurent Desnogues @ 2009-10-18 14:29 UTC (permalink / raw)
To: Aurelien Jarno; +Cc: qemu-devel
On Thu, Oct 15, 2009 at 11:51 PM, Aurelien Jarno <aurelien@aurel32.net> wrote:
> Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
> ---
> target-arm/translate.c | 4 ++++
> 1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/target-arm/translate.c b/target-arm/translate.c
> index 0c10ac2..bb0f8ef 100644
> --- a/target-arm/translate.c
> +++ b/target-arm/translate.c
> @@ -8805,6 +8805,10 @@ static inline void gen_intermediate_code_internal(CPUState *env,
> if (num_insns + 1 == max_insns && (tb->cflags & CF_LAST_IO))
> gen_io_start();
>
> + if (unlikely(qemu_loglevel_mask(CPU_LOG_TB_OP))) {
> + tcg_gen_debug_insn_start(dc->pc);
> + }
> +
> if (env->thumb) {
> disas_thumb_insn(env, dc);
> if (dc->condexec_mask) {
> --
> 1.6.1.3
Shouldn't you dump the TCG debug instruction before the
check for gen_io_start?
Laurent
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] target-arm: log instructions start in TCG code
2009-10-18 14:29 ` Laurent Desnogues
@ 2009-10-22 20:55 ` Aurelien Jarno
0 siblings, 0 replies; 3+ messages in thread
From: Aurelien Jarno @ 2009-10-22 20:55 UTC (permalink / raw)
To: Laurent Desnogues; +Cc: qemu-devel
On Sun, Oct 18, 2009 at 04:29:52PM +0200, Laurent Desnogues wrote:
> On Thu, Oct 15, 2009 at 11:51 PM, Aurelien Jarno <aurelien@aurel32.net> wrote:
> > Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
> > ---
> > target-arm/translate.c | 4 ++++
> > 1 files changed, 4 insertions(+), 0 deletions(-)
> >
> > diff --git a/target-arm/translate.c b/target-arm/translate.c
> > index 0c10ac2..bb0f8ef 100644
> > --- a/target-arm/translate.c
> > +++ b/target-arm/translate.c
> > @@ -8805,6 +8805,10 @@ static inline void gen_intermediate_code_internal(CPUState *env,
> > if (num_insns + 1 == max_insns && (tb->cflags & CF_LAST_IO))
> > gen_io_start();
> >
> > + if (unlikely(qemu_loglevel_mask(CPU_LOG_TB_OP))) {
> > + tcg_gen_debug_insn_start(dc->pc);
> > + }
> > +
> > if (env->thumb) {
> > disas_thumb_insn(env, dc);
> > if (dc->condexec_mask) {
> > --
> > 1.6.1.3
>
> Shouldn't you dump the TCG debug instruction before the
> check for gen_io_start?
>
Good question. I have mainly added this debug code at the same
location as on other architecture. The question is does the gen_io
code actually belong to an op?
--
Aurelien Jarno GPG: 1024D/F1BCDB73
aurelien@aurel32.net http://www.aurel32.net
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-10-22 20:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-10-15 21:51 [Qemu-devel] [PATCH] target-arm: log instructions start in TCG code Aurelien Jarno
2009-10-18 14:29 ` Laurent Desnogues
2009-10-22 20:55 ` Aurelien Jarno
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).