From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1N2LZU-0000dc-TE
	for qemu-devel@nongnu.org; Mon, 26 Oct 2009 05:09:00 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1N2LZS-0000bz-TC
	for qemu-devel@nongnu.org; Mon, 26 Oct 2009 05:08:59 -0400
Received: from [199.232.76.173] (port=51999 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1N2LZS-0000bw-OA
	for qemu-devel@nongnu.org; Mon, 26 Oct 2009 05:08:58 -0400
Received: from fg-out-1718.google.com ([72.14.220.159]:40366)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <laurent.desnogues@gmail.com>) id 1N2LZS-0001ai-D5
	for qemu-devel@nongnu.org; Mon, 26 Oct 2009 05:08:58 -0400
Received: by fg-out-1718.google.com with SMTP id d23so4076754fga.10
	for <qemu-devel@nongnu.org>; Mon, 26 Oct 2009 02:08:57 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <74E08B35-7E60-4123-8B10-FAA854A740B6@nokia.com>
References: <1256386749-85299-1-git-send-email-juha.riihimaki@nokia.com>
	<1256386749-85299-4-git-send-email-juha.riihimaki@nokia.com>
	<761ea48b0910250523t513f6c54t6bade67aef71cd0a@mail.gmail.com>
	<74E08B35-7E60-4123-8B10-FAA854A740B6@nokia.com>
Date: Mon, 26 Oct 2009 10:08:57 +0100
Message-ID: <761ea48b0910260208m540e6316s7b0f02c18f4d3800@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH v2 03/10] target-arm: allow modifying vfp
	fpexc en bit only
From: Laurent Desnogues <laurent.desnogues@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Juha.Riihimaki@nokia.com
Cc: qemu-devel@nongnu.org

On Mon, Oct 26, 2009 at 8:32 AM,  <Juha.Riihimaki@nokia.com> wrote:
[...]
>>
>> Shouldn't writes to FPEXC from gdb be protected in the same
>> way? =A0Except for that I agree with your patch.
>
> Please correct me if I'm wrong but it seems to me that the code in
> gdbstub.c never writes anything to the VFP registers, at least it
> seems to me the code in cpu_gdb_write_register and
> cpu_gdb_read_register ignore floating point registers.

There's code in helper.c that implements writes to coprocessor
registers.  Look for vfp_gdb_set_reg which is registered by
cpu_arm_init.


Laurent