* [Qemu-devel] [PATCH] target-arm: fix incorrect temporary variable freeing
@ 2009-10-26 11:02 juha.riihimaki
2009-10-26 11:21 ` Laurent Desnogues
0 siblings, 1 reply; 2+ messages in thread
From: juha.riihimaki @ 2009-10-26 11:02 UTC (permalink / raw)
To: qemu-devel
From: Juha Riihimäki <juha.riihimaki@nokia.com>
tmp4 and tmp5 temporary variables are allocated using tcg_const_i32
but incorrectly released using dead_tmp which will cause resource
leak tracking to report false leaks.
Signed-off-by: Juha Riihimäki <juha.riihimaki@nokia.com>
---
target-arm/translate.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/target-arm/translate.c b/target-arm/translate.c
index 9d13d42..1988cc6 100644
--- a/target-arm/translate.c
+++ b/target-arm/translate.c
@@ -5535,8 +5535,8 @@ static int disas_neon_data_insn(CPUState * env, DisasContext *s, uint32_t insn)
}
tmp3 = neon_load_reg(rm, 1);
gen_helper_neon_tbl(tmp3, tmp3, tmp, tmp4, tmp5);
- dead_tmp(tmp5);
- dead_tmp(tmp4);
+ tcg_temp_free_i32(tmp5);
+ tcg_temp_free_i32(tmp4);
neon_store_reg(rd, 0, tmp2);
neon_store_reg(rd, 1, tmp3);
dead_tmp(tmp);
--
1.6.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] target-arm: fix incorrect temporary variable freeing
2009-10-26 11:02 [Qemu-devel] [PATCH] target-arm: fix incorrect temporary variable freeing juha.riihimaki
@ 2009-10-26 11:21 ` Laurent Desnogues
0 siblings, 0 replies; 2+ messages in thread
From: Laurent Desnogues @ 2009-10-26 11:21 UTC (permalink / raw)
To: juha.riihimaki; +Cc: qemu-devel
On Mon, Oct 26, 2009 at 12:02 PM, <juha.riihimaki@nokia.com> wrote:
> From: Juha Riihimäki <juha.riihimaki@nokia.com>
>
> tmp4 and tmp5 temporary variables are allocated using tcg_const_i32
> but incorrectly released using dead_tmp which will cause resource
> leak tracking to report false leaks.
>
> Signed-off-by: Juha Riihimäki <juha.riihimaki@nokia.com>
Acked-by: Laurent Desnogues <laurent.desnogues@gmail.com>
Laurent
> ---
> target-arm/translate.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/target-arm/translate.c b/target-arm/translate.c
> index 9d13d42..1988cc6 100644
> --- a/target-arm/translate.c
> +++ b/target-arm/translate.c
> @@ -5535,8 +5535,8 @@ static int disas_neon_data_insn(CPUState * env, DisasContext *s, uint32_t insn)
> }
> tmp3 = neon_load_reg(rm, 1);
> gen_helper_neon_tbl(tmp3, tmp3, tmp, tmp4, tmp5);
> - dead_tmp(tmp5);
> - dead_tmp(tmp4);
> + tcg_temp_free_i32(tmp5);
> + tcg_temp_free_i32(tmp4);
> neon_store_reg(rd, 0, tmp2);
> neon_store_reg(rd, 1, tmp3);
> dead_tmp(tmp);
> --
> 1.6.5
>
>
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-10-26 11:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-10-26 11:02 [Qemu-devel] [PATCH] target-arm: fix incorrect temporary variable freeing juha.riihimaki
2009-10-26 11:21 ` Laurent Desnogues
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).