From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1N2Ndc-0000fN-Ck
	for qemu-devel@nongnu.org; Mon, 26 Oct 2009 07:21:24 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1N2Nda-0000eq-Rf
	for qemu-devel@nongnu.org; Mon, 26 Oct 2009 07:21:23 -0400
Received: from [199.232.76.173] (port=59605 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1N2Nda-0000en-O7
	for qemu-devel@nongnu.org; Mon, 26 Oct 2009 07:21:22 -0400
Received: from fg-out-1718.google.com ([72.14.220.152]:32162)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <laurent.desnogues@gmail.com>) id 1N2Nda-0003YZ-Ez
	for qemu-devel@nongnu.org; Mon, 26 Oct 2009 07:21:22 -0400
Received: by fg-out-1718.google.com with SMTP id 16so822415fgg.10
	for <qemu-devel@nongnu.org>; Mon, 26 Oct 2009 04:21:21 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <1256554957-2279-1-git-send-email-juha.riihimaki@nokia.com>
References: <1256554957-2279-1-git-send-email-juha.riihimaki@nokia.com>
Date: Mon, 26 Oct 2009 12:21:20 +0100
Message-ID: <761ea48b0910260421h37092886h96f70e32956e0b21@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH] target-arm: fix incorrect temporary variable
	freeing
From: Laurent Desnogues <laurent.desnogues@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: juha.riihimaki@nokia.com
Cc: qemu-devel@nongnu.org

On Mon, Oct 26, 2009 at 12:02 PM,  <juha.riihimaki@nokia.com> wrote:
> From: Juha Riihim=E4ki <juha.riihimaki@nokia.com>
>
> tmp4 and tmp5 temporary variables are allocated using tcg_const_i32
> but incorrectly released using dead_tmp which will cause resource
> leak tracking to report false leaks.
>
> Signed-off-by: Juha Riihim=E4ki <juha.riihimaki@nokia.com>

Acked-by:  Laurent Desnogues <laurent.desnogues@gmail.com>


Laurent

> ---
> =A0target-arm/translate.c | =A0 =A04 ++--
> =A01 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/target-arm/translate.c b/target-arm/translate.c
> index 9d13d42..1988cc6 100644
> --- a/target-arm/translate.c
> +++ b/target-arm/translate.c
> @@ -5535,8 +5535,8 @@ static int disas_neon_data_insn(CPUState * env, Dis=
asContext *s, uint32_t insn)
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 }
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 tmp3 =3D neon_load_reg(rm, 1);
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 gen_helper_neon_tbl(tmp3, tmp3, tmp, tmp4=
, tmp5);
> - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0dead_tmp(tmp5);
> - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0dead_tmp(tmp4);
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0tcg_temp_free_i32(tmp5);
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0tcg_temp_free_i32(tmp4);
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 neon_store_reg(rd, 0, tmp2);
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 neon_store_reg(rd, 1, tmp3);
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 dead_tmp(tmp);
> --
> 1.6.5
>
>
>
>