From: Laurent Desnogues <laurent.desnogues@gmail.com>
To: juha.riihimaki@nokia.com
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v3] target-arm: fix neon shift helper functions
Date: Tue, 27 Oct 2009 08:17:15 +0100 [thread overview]
Message-ID: <761ea48b0910270017u21061aes9d02eded50758f85@mail.gmail.com> (raw)
In-Reply-To: <1256540467-87779-1-git-send-email-juha.riihimaki@nokia.com>
On Mon, Oct 26, 2009 at 8:01 AM, <juha.riihimaki@nokia.com> wrote:
> From: Juha Riihimäki <juha.riihimaki@nokia.com>
>
> Current code is broken at least on recent compilers, comparison
> between signed and unsigned types yield incorrect code and render
> the neon shift helper functions defunct. This is the third revision
> of this patch, casting all comparisons with the sizeof operator to
> signed ssize_t type to force comparisons to be between signed integral
> types.
>
> Signed-off-by: Juha Riihimäki <juha.riihimaki@nokia.com>
Acked-by: Laurent Desnogues <laurent.desnogues@gmail.com>
Laurent
> ---
> target-arm/neon_helper.c | 26 ++++++++++++++------------
> 1 files changed, 14 insertions(+), 12 deletions(-)
>
> diff --git a/target-arm/neon_helper.c b/target-arm/neon_helper.c
> index f32ecd6..5e6452b 100644
> --- a/target-arm/neon_helper.c
> +++ b/target-arm/neon_helper.c
> @@ -392,7 +392,8 @@ NEON_VOP(abd_u32, neon_u32, 1)
> #define NEON_FN(dest, src1, src2) do { \
> int8_t tmp; \
> tmp = (int8_t)src2; \
> - if (tmp >= sizeof(src1) * 8 || tmp <= -sizeof(src1) * 8) { \
> + if (tmp >= (ssize_t)sizeof(src1) * 8 || \
> + tmp <= -(ssize_t)sizeof(src1) * 8) { \
> dest = 0; \
> } else if (tmp < 0) { \
> dest = src1 >> -tmp; \
> @@ -420,9 +421,9 @@ uint64_t HELPER(neon_shl_u64)(uint64_t val, uint64_t shiftop)
> #define NEON_FN(dest, src1, src2) do { \
> int8_t tmp; \
> tmp = (int8_t)src2; \
> - if (tmp >= sizeof(src1) * 8) { \
> + if (tmp >= (ssize_t)sizeof(src1) * 8) { \
> dest = 0; \
> - } else if (tmp <= -sizeof(src1) * 8) { \
> + } else if (tmp <= -(ssize_t)sizeof(src1) * 8) { \
> dest = src1 >> (sizeof(src1) * 8 - 1); \
> } else if (tmp < 0) { \
> dest = src1 >> -tmp; \
> @@ -453,11 +454,11 @@ uint64_t HELPER(neon_shl_s64)(uint64_t valop, uint64_t shiftop)
> #define NEON_FN(dest, src1, src2) do { \
> int8_t tmp; \
> tmp = (int8_t)src2; \
> - if (tmp >= sizeof(src1) * 8) { \
> + if (tmp >= (ssize_t)sizeof(src1) * 8) { \
> dest = 0; \
> - } else if (tmp < -sizeof(src1) * 8) { \
> + } else if (tmp < -(ssize_t)sizeof(src1) * 8) { \
> dest = src1 >> (sizeof(src1) * 8 - 1); \
> - } else if (tmp == -sizeof(src1) * 8) { \
> + } else if (tmp == -(ssize_t)sizeof(src1) * 8) { \
> dest = src1 >> (tmp - 1); \
> dest++; \
> dest >>= 1; \
> @@ -494,9 +495,10 @@ uint64_t HELPER(neon_rshl_s64)(uint64_t valop, uint64_t shiftop)
> #define NEON_FN(dest, src1, src2) do { \
> int8_t tmp; \
> tmp = (int8_t)src2; \
> - if (tmp >= sizeof(src1) * 8 || tmp < -sizeof(src1) * 8) { \
> + if (tmp >= (ssize_t)sizeof(src1) * 8 || \
> + tmp < -(ssize_t)sizeof(src1) * 8) { \
> dest = 0; \
> - } else if (tmp == -sizeof(src1) * 8) { \
> + } else if (tmp == -(ssize_t)sizeof(src1) * 8) { \
> dest = src1 >> (tmp - 1); \
> } else if (tmp < 0) { \
> dest = (src1 + (1 << (-1 - tmp))) >> -tmp; \
> @@ -528,14 +530,14 @@ uint64_t HELPER(neon_rshl_u64)(uint64_t val, uint64_t shiftop)
> #define NEON_FN(dest, src1, src2) do { \
> int8_t tmp; \
> tmp = (int8_t)src2; \
> - if (tmp >= sizeof(src1) * 8) { \
> + if (tmp >= (ssize_t)sizeof(src1) * 8) { \
> if (src1) { \
> SET_QC(); \
> dest = ~0; \
> } else { \
> dest = 0; \
> } \
> - } else if (tmp <= -sizeof(src1) * 8) { \
> + } else if (tmp <= -(ssize_t)sizeof(src1) * 8) { \
> dest = 0; \
> } else if (tmp < 0) { \
> dest = src1 >> -tmp; \
> @@ -579,11 +581,11 @@ uint64_t HELPER(neon_qshl_u64)(CPUState *env, uint64_t val, uint64_t shiftop)
> #define NEON_FN(dest, src1, src2) do { \
> int8_t tmp; \
> tmp = (int8_t)src2; \
> - if (tmp >= sizeof(src1) * 8) { \
> + if (tmp >= (ssize_t)sizeof(src1) * 8) { \
> if (src1) \
> SET_QC(); \
> dest = src1 >> 31; \
> - } else if (tmp <= -sizeof(src1) * 8) { \
> + } else if (tmp <= -(ssize_t)sizeof(src1) * 8) { \
> dest = src1 >> 31; \
> } else if (tmp < 0) { \
> dest = src1 >> -tmp; \
> --
> 1.6.5
>
>
>
>
prev parent reply other threads:[~2009-10-27 7:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-26 7:01 [Qemu-devel] [PATCH v3] target-arm: fix neon shift helper functions juha.riihimaki
2009-10-27 7:17 ` Laurent Desnogues [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=761ea48b0910270017u21061aes9d02eded50758f85@mail.gmail.com \
--to=laurent.desnogues@gmail.com \
--cc=juha.riihimaki@nokia.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).