From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1N2gJ0-0002AU-2P for qemu-devel@nongnu.org; Tue, 27 Oct 2009 03:17:22 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1N2gIz-0002AI-7B for qemu-devel@nongnu.org; Tue, 27 Oct 2009 03:17:21 -0400 Received: from [199.232.76.173] (port=50601 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N2gIz-0002AF-2M for qemu-devel@nongnu.org; Tue, 27 Oct 2009 03:17:21 -0400 Received: from fg-out-1718.google.com ([72.14.220.152]:23947) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1N2gIy-0003z0-LE for qemu-devel@nongnu.org; Tue, 27 Oct 2009 03:17:20 -0400 Received: by fg-out-1718.google.com with SMTP id 16so1096076fgg.10 for ; Tue, 27 Oct 2009 00:17:19 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1256540467-87779-1-git-send-email-juha.riihimaki@nokia.com> References: <1256540467-87779-1-git-send-email-juha.riihimaki@nokia.com> Date: Tue, 27 Oct 2009 08:17:15 +0100 Message-ID: <761ea48b0910270017u21061aes9d02eded50758f85@mail.gmail.com> Subject: Re: [Qemu-devel] [PATCH v3] target-arm: fix neon shift helper functions From: Laurent Desnogues Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: juha.riihimaki@nokia.com Cc: qemu-devel@nongnu.org On Mon, Oct 26, 2009 at 8:01 AM, wrote: > From: Juha Riihim=E4ki > > Current code is broken at least on recent compilers, comparison > between signed and unsigned types yield incorrect code and render > the neon shift helper functions defunct. This is the third revision > of this patch, casting all comparisons with the sizeof operator to > signed ssize_t type to force comparisons to be between signed integral > types. > > Signed-off-by: Juha Riihim=E4ki Acked-by: Laurent Desnogues Laurent > --- > =A0target-arm/neon_helper.c | =A0 26 ++++++++++++++------------ > =A01 files changed, 14 insertions(+), 12 deletions(-) > > diff --git a/target-arm/neon_helper.c b/target-arm/neon_helper.c > index f32ecd6..5e6452b 100644 > --- a/target-arm/neon_helper.c > +++ b/target-arm/neon_helper.c > @@ -392,7 +392,8 @@ NEON_VOP(abd_u32, neon_u32, 1) > =A0#define NEON_FN(dest, src1, src2) do { \ > =A0 =A0 int8_t tmp; \ > =A0 =A0 tmp =3D (int8_t)src2; \ > - =A0 =A0if (tmp >=3D sizeof(src1) * 8 || tmp <=3D -sizeof(src1) * 8) { \ > + =A0 =A0if (tmp >=3D (ssize_t)sizeof(src1) * 8 || \ > + =A0 =A0 =A0 =A0tmp <=3D -(ssize_t)sizeof(src1) * 8) { \ > =A0 =A0 =A0 =A0 dest =3D 0; \ > =A0 =A0 } else if (tmp < 0) { \ > =A0 =A0 =A0 =A0 dest =3D src1 >> -tmp; \ > @@ -420,9 +421,9 @@ uint64_t HELPER(neon_shl_u64)(uint64_t val, uint64_t = shiftop) > =A0#define NEON_FN(dest, src1, src2) do { \ > =A0 =A0 int8_t tmp; \ > =A0 =A0 tmp =3D (int8_t)src2; \ > - =A0 =A0if (tmp >=3D sizeof(src1) * 8) { \ > + =A0 =A0if (tmp >=3D (ssize_t)sizeof(src1) * 8) { \ > =A0 =A0 =A0 =A0 dest =3D 0; \ > - =A0 =A0} else if (tmp <=3D -sizeof(src1) * 8) { \ > + =A0 =A0} else if (tmp <=3D -(ssize_t)sizeof(src1) * 8) { \ > =A0 =A0 =A0 =A0 dest =3D src1 >> (sizeof(src1) * 8 - 1); \ > =A0 =A0 } else if (tmp < 0) { \ > =A0 =A0 =A0 =A0 dest =3D src1 >> -tmp; \ > @@ -453,11 +454,11 @@ uint64_t HELPER(neon_shl_s64)(uint64_t valop, uint6= 4_t shiftop) > =A0#define NEON_FN(dest, src1, src2) do { \ > =A0 =A0 int8_t tmp; \ > =A0 =A0 tmp =3D (int8_t)src2; \ > - =A0 =A0if (tmp >=3D sizeof(src1) * 8) { \ > + =A0 =A0if (tmp >=3D (ssize_t)sizeof(src1) * 8) { \ > =A0 =A0 =A0 =A0 dest =3D 0; \ > - =A0 =A0} else if (tmp < -sizeof(src1) * 8) { \ > + =A0 =A0} else if (tmp < -(ssize_t)sizeof(src1) * 8) { \ > =A0 =A0 =A0 =A0 dest =3D src1 >> (sizeof(src1) * 8 - 1); \ > - =A0 =A0} else if (tmp =3D=3D -sizeof(src1) * 8) { \ > + =A0 =A0} else if (tmp =3D=3D -(ssize_t)sizeof(src1) * 8) { \ > =A0 =A0 =A0 =A0 dest =3D src1 >> (tmp - 1); \ > =A0 =A0 =A0 =A0 dest++; \ > =A0 =A0 =A0 =A0 dest >>=3D 1; \ > @@ -494,9 +495,10 @@ uint64_t HELPER(neon_rshl_s64)(uint64_t valop, uint6= 4_t shiftop) > =A0#define NEON_FN(dest, src1, src2) do { \ > =A0 =A0 int8_t tmp; \ > =A0 =A0 tmp =3D (int8_t)src2; \ > - =A0 =A0if (tmp >=3D sizeof(src1) * 8 || tmp < -sizeof(src1) * 8) { \ > + =A0 =A0if (tmp >=3D (ssize_t)sizeof(src1) * 8 || \ > + =A0 =A0 =A0 =A0tmp < -(ssize_t)sizeof(src1) * 8) { \ > =A0 =A0 =A0 =A0 dest =3D 0; \ > - =A0 =A0} else if (tmp =3D=3D -sizeof(src1) * 8) { \ > + =A0 =A0} else if (tmp =3D=3D -(ssize_t)sizeof(src1) * 8) { \ > =A0 =A0 =A0 =A0 dest =3D src1 >> (tmp - 1); \ > =A0 =A0 } else if (tmp < 0) { \ > =A0 =A0 =A0 =A0 dest =3D (src1 + (1 << (-1 - tmp))) >> -tmp; \ > @@ -528,14 +530,14 @@ uint64_t HELPER(neon_rshl_u64)(uint64_t val, uint64= _t shiftop) > =A0#define NEON_FN(dest, src1, src2) do { \ > =A0 =A0 int8_t tmp; \ > =A0 =A0 tmp =3D (int8_t)src2; \ > - =A0 =A0if (tmp >=3D sizeof(src1) * 8) { \ > + =A0 =A0if (tmp >=3D (ssize_t)sizeof(src1) * 8) { \ > =A0 =A0 =A0 =A0 if (src1) { \ > =A0 =A0 =A0 =A0 =A0 =A0 SET_QC(); \ > =A0 =A0 =A0 =A0 =A0 =A0 dest =3D ~0; \ > =A0 =A0 =A0 =A0 } else { \ > =A0 =A0 =A0 =A0 =A0 =A0 dest =3D 0; \ > =A0 =A0 =A0 =A0 } \ > - =A0 =A0} else if (tmp <=3D -sizeof(src1) * 8) { \ > + =A0 =A0} else if (tmp <=3D -(ssize_t)sizeof(src1) * 8) { \ > =A0 =A0 =A0 =A0 dest =3D 0; \ > =A0 =A0 } else if (tmp < 0) { \ > =A0 =A0 =A0 =A0 dest =3D src1 >> -tmp; \ > @@ -579,11 +581,11 @@ uint64_t HELPER(neon_qshl_u64)(CPUState *env, uint6= 4_t val, uint64_t shiftop) > =A0#define NEON_FN(dest, src1, src2) do { \ > =A0 =A0 int8_t tmp; \ > =A0 =A0 tmp =3D (int8_t)src2; \ > - =A0 =A0if (tmp >=3D sizeof(src1) * 8) { \ > + =A0 =A0if (tmp >=3D (ssize_t)sizeof(src1) * 8) { \ > =A0 =A0 =A0 =A0 if (src1) \ > =A0 =A0 =A0 =A0 =A0 =A0 SET_QC(); \ > =A0 =A0 =A0 =A0 dest =3D src1 >> 31; \ > - =A0 =A0} else if (tmp <=3D -sizeof(src1) * 8) { \ > + =A0 =A0} else if (tmp <=3D -(ssize_t)sizeof(src1) * 8) { \ > =A0 =A0 =A0 =A0 dest =3D src1 >> 31; \ > =A0 =A0 } else if (tmp < 0) { \ > =A0 =A0 =A0 =A0 dest =3D src1 >> -tmp; \ > -- > 1.6.5 > > > >