From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1N3VQp-0002oa-BW for qemu-devel@nongnu.org; Thu, 29 Oct 2009 09:52:51 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1N3VQo-0002nX-0K for qemu-devel@nongnu.org; Thu, 29 Oct 2009 09:52:50 -0400 Received: from [199.232.76.173] (port=48271 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N3VQm-0002n5-PB for qemu-devel@nongnu.org; Thu, 29 Oct 2009 09:52:49 -0400 Received: from fg-out-1718.google.com ([72.14.220.153]:7964) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1N3VQm-0006ld-BL for qemu-devel@nongnu.org; Thu, 29 Oct 2009 09:52:48 -0400 Received: by fg-out-1718.google.com with SMTP id 16so2160359fgg.10 for ; Thu, 29 Oct 2009 06:52:47 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <893C7C0C-D539-403E-B404-EB0EE87E9437@nokia.com> References: <1256386749-85299-1-git-send-email-juha.riihimaki@nokia.com> <1256386749-85299-10-git-send-email-juha.riihimaki@nokia.com> <761ea48b0910250701q3a452eaama8a07059ed8aec30@mail.gmail.com> <4F9750C3-A196-4518-8021-D02BFE645A4F@nokia.com> <761ea48b0910260211k12d199c5l794eb0f9d45e3b77@mail.gmail.com> <20091026210502.GT26129@hall.aurel32.net> <893C7C0C-D539-403E-B404-EB0EE87E9437@nokia.com> Date: Thu, 29 Oct 2009 14:52:47 +0100 Message-ID: <761ea48b0910290652r278fd815ua60d75f7a2e99716@mail.gmail.com> Subject: Re: [Qemu-devel] [PATCH v2 09/10] target-arm: optimize neon vld/vst ops From: Laurent Desnogues Content-Type: text/plain; charset=ISO-8859-1 List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juha.Riihimaki@nokia.com Cc: qemu-devel@nongnu.org, aurelien@aurel32.net On Thu, Oct 29, 2009 at 2:45 PM, wrote: [...] > > Alrighty then, I did the patch against the latest git and it's rather > large... but seems to have broken nothing at least in my testing. The > patch will remove all implicit tcg temp variable allocation and > deallocation in target-arm/translate.c and make it the responsibility > of the calling function. At the same time I also removed the new_tmp > and dead_tmp functions completely because I see no point in only > tracking some of the 32bit temp variables instead of everything. > Personally I think the patch makes reading and understanding (and why > not also writing) the file much easier. I do also have a version that > has a compile time option of substituting the tcg temp variable alloc/ > dealloc function calls with inline functions that track the usage but > this is not included with the patch. I was thinking about alloc/dealloc problems and I think a good way of detecting issues is to exercise all target instructions. It can be done easily with some bit trickery for targets with regular encodings. I have already done so for a new target and this helps a lot; it only required a few dozens lines of code, but it's hacky :-) > I'll send the patch shortly, should be nice bed-time reading I > guess ;) Please comment when you have free time to read it through... Nice! Laurent