From: Laurent Desnogues <laurent.desnogues@gmail.com>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: Glauber Costa <glommer@redhat.com>,
aliguori@us.ibm.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] v3: don't call reset functions on cpu initialization
Date: Fri, 6 Nov 2009 20:13:19 +0100 [thread overview]
Message-ID: <761ea48b0911061113n7f254ac4wd1d9f994abe0f53a@mail.gmail.com> (raw)
In-Reply-To: <f43fc5580911061101w6334864exa57a81d182df7bdc@mail.gmail.com>
On Fri, Nov 6, 2009 at 8:01 PM, Blue Swirl <blauwirbel@gmail.com> wrote:
> On Fri, Nov 6, 2009 at 8:43 PM, Laurent Desnogues
> <laurent.desnogues@gmail.com> wrote:
[...]
>> I honestly don't care that much as long as all targets still work
>> in user mode :-)
>>
>> The aim was to make Glauber's patch less intrusive.
>
> Given that only the new calls to cpu_reset are important and the
> removals are much less so (double reset shouldn't be a problem), the
> least intrusive version would be to just add the new calls and do the
> clean up later.
Multiple resets would result in memory leaks for MIPS for instance.
So I don't think they are that innocuous. Though that probably is
more a problem of the MIPS reset than anything else :-)
Laurent
next prev parent reply other threads:[~2009-11-06 19:13 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-05 16:05 [Qemu-devel] [PATCH] v3: don't call reset functions on cpu initialization Glauber Costa
2009-11-06 18:05 ` Blue Swirl
2009-11-06 18:11 ` Glauber Costa
2009-11-06 18:43 ` Laurent Desnogues
2009-11-06 19:01 ` Blue Swirl
2009-11-06 19:13 ` Laurent Desnogues [this message]
2009-11-06 19:36 ` Blue Swirl
2009-11-06 19:50 ` Laurent Desnogues
2009-11-06 19:54 ` Blue Swirl
2009-11-06 20:41 ` Glauber Costa
2009-11-07 8:40 ` Blue Swirl
2009-11-07 16:02 ` Laurent Desnogues
2009-11-07 16:11 ` Blue Swirl
2009-11-07 16:15 ` Laurent Desnogues
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=761ea48b0911061113n7f254ac4wd1d9f994abe0f53a@mail.gmail.com \
--to=laurent.desnogues@gmail.com \
--cc=aliguori@us.ibm.com \
--cc=blauwirbel@gmail.com \
--cc=glommer@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).