From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NLb9m-00041F-FJ for qemu-devel@nongnu.org; Fri, 18 Dec 2009 06:38:02 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NLb9h-0003z6-Ka for qemu-devel@nongnu.org; Fri, 18 Dec 2009 06:38:01 -0500 Received: from [199.232.76.173] (port=46935 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NLb9h-0003yr-7E for qemu-devel@nongnu.org; Fri, 18 Dec 2009 06:37:57 -0500 Received: from mail-px0-f189.google.com ([209.85.216.189]:46624) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NLb9g-0007Gx-II for qemu-devel@nongnu.org; Fri, 18 Dec 2009 06:37:57 -0500 Received: by pxi27 with SMTP id 27so362897pxi.4 for ; Fri, 18 Dec 2009 03:37:52 -0800 (PST) MIME-Version: 1.0 In-Reply-To: References: <761ea48b0912170620l534dcb02m8ea6b59524d76dbe@mail.gmail.com> Date: Fri, 18 Dec 2009 12:37:51 +0100 Message-ID: <761ea48b0912180337k627350b7ma7ab54cd248815eb@mail.gmail.com> From: Laurent Desnogues Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] Re: [PATCH 0/6] tcg conditional set/move, round 2 List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson Cc: qemu-devel@nongnu.org On Thu, Dec 17, 2009 at 8:32 PM, Richard Henderson wrote: >> funny how you seem to follow the same paths I did months ago :-) > > Heh. =A0They are the obvious points for improvement in the emulation. > Hopefully we can get them finished this time, so that some third > person doesn't go through the same thing next year. =A0=3D) I agree :-) >> - cosmetics: don't use tabs and be sure not to have >> =A0 whitespaces at end of lines > > Grr, I thought I'd been extra careful about that. =A0Fixed. > >> - the changes to tcg-op.h in patch 6 should go with patch 1 > > Done. > >> - outside of the small parameter handling, I'd prefer >> =A0 you provide a separate patch for tcg_out_brcond2; >> =A0 I don't think the changes using c1, c2 and c3 really >> =A0 belong to setcond/movcond. > > The i386 part has been split into 3 patches, though they > are sequentially dependent. > > I've left off the sparc backend patch, as well as the patches > for the translators. =A0Let's take care of these first. Thanks, that will make things easier. > > r~ > --- > > Richard Henderson (6): This is a first pass of review. It's far complete (in particular no testing was done). Here is a summary of my comments: > =A0tcg: Generic support for conditional set and conditional move. Needs cosmetics changes. > =A0tcg: Add tcg_invert_cond. OK. > =A0tcg-x86_64: Implement setcond and movcond. Some cosmetics and comments, but overall good. > =A0tcg-i386: Implement small forward branches. I think this contains a bug. > =A0tcg-i386: Simplify brcond2. I don't like the rewrite of brcond2. > =A0tcg-i386: Implement setcond, movcond, setcond2. Not yet reviewed. Laurent > > =A0elf.h =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 | =A0 =A02 + > =A0tcg/README =A0 =A0 =A0 =A0 =A0 =A0 =A0| =A0 26 ++++- > =A0tcg/i386/tcg-target.c =A0 | =A0278 +++++++++++++++++++++++++++++++++++= +++-------- > =A0tcg/tcg-op.h =A0 =A0 =A0 =A0 =A0 =A0| =A0 91 +++++++++++++++ > =A0tcg/tcg-opc.h =A0 =A0 =A0 =A0 =A0 | =A0 =A05 + > =A0tcg/tcg.c =A0 =A0 =A0 =A0 =A0 =A0 =A0 | =A0 23 +++- > =A0tcg/tcg.h =A0 =A0 =A0 =A0 =A0 =A0 =A0 | =A0 =A05 + > =A0tcg/x86_64/tcg-target.c | =A0 65 +++++++++++- > =A08 files changed, 436 insertions(+), 59 deletions(-) > >