From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NLxfL-0005i9-PM
	for qemu-devel@nongnu.org; Sat, 19 Dec 2009 06:40:07 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NLxfH-0005hM-7w
	for qemu-devel@nongnu.org; Sat, 19 Dec 2009 06:40:07 -0500
Received: from [199.232.76.173] (port=43730 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NLxfH-0005hI-34
	for qemu-devel@nongnu.org; Sat, 19 Dec 2009 06:40:03 -0500
Received: from mail-pz0-f188.google.com ([209.85.222.188]:53209)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <laurent.desnogues@gmail.com>) id 1NLxfG-00033Z-KL
	for qemu-devel@nongnu.org; Sat, 19 Dec 2009 06:40:02 -0500
Received: by pzk26 with SMTP id 26so2226833pzk.4
	for <qemu-devel@nongnu.org>; Sat, 19 Dec 2009 03:40:01 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <4B2BF650.80902@twiddle.net>
References: <761ea48b0912170620l534dcb02m8ea6b59524d76dbe@mail.gmail.com>
	<cover.1261078375.git.rth@twiddle.net>
	<761ea48b0912180337k627350b7ma7ab54cd248815eb@mail.gmail.com>
	<4B2BF650.80902@twiddle.net>
Date: Sat, 19 Dec 2009 12:40:01 +0100
Message-ID: <761ea48b0912190340u13ae5f3cib628bc283b3286d1@mail.gmail.com>
From: Laurent Desnogues <laurent.desnogues@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: [Qemu-devel] Re: tcg conditional set/move, round 3
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>
Cc: qemu-devel@nongnu.org

On Fri, Dec 18, 2009 at 10:38 PM, Richard Henderson <rth@twiddle.net> wrote=
:
> On 12/18/2009 03:37 AM, Laurent Desnogues wrote:
>>>
>>> =A0tcg: Generic support for conditional set and conditional move.
>>
>> Needs cosmetics changes.
>
> Fixed, attachment 1.
>
>>> =A0tcg-x86_64: Implement setcond and movcond.
>>
>> Some cosmetics and comments, but overall good.
>
> Fixed, attachment 2.
>
>>> =A0tcg-i386: Implement small forward branches.
>>
>> I think this contains a bug.
>
> Fixed, attachment 3. =A0I've added an abort to patch_reloc to verify that=
 the
> relocation is in range. =A0I've propagated the "small" flag to all of the
> branch functions so that...
>
>>> =A0tcg-i386: Simplify brcond2.
>>
>> I don't like the rewrite of brcond2.
>
> ... this patch is dropped.
>
>>> =A0tcg-i386: Implement setcond, movcond, setcond2.
>>
>> Not yet reviewed.
>
> Fixed, attachment 4. =A0Similar changes to the amd64 patch.

Everything looks good to me, though for i386 I'd not bet
my life it's 100% correct.  OTOH I think this is good enough
to go into mainline, so that people can start adding support
in the front-ends.

BTW for compiling to 32-bit on a 64-bit x86, the configure
script is broken as it checks gcc before having set -m32,
so passing -march=3Di686 will make it fail (in the end it means
I could not convince QEMU to use cmov :-).

Thanks,

Laurent

Acked-by: Laurent Desnogues <laurent.desnogues@gmail.com>