From: Laurent Desnogues <laurent.desnogues@gmail.com>
To: Juan Quintela <quintela@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 17/17] mmap_frag() users only check for -1 error
Date: Mon, 25 Jan 2010 09:53:03 +0100 [thread overview]
Message-ID: <761ea48b1001250053y39d62dc7t59bcdeddeff90277@mail.gmail.com> (raw)
In-Reply-To: <783b5271b3a305f0fd9e4bf346f3c7f430311003.1264017981.git.quintela@redhat.com>
On Wed, Jan 20, 2010 at 9:14 PM, Juan Quintela <quintela@redhat.com> wrote:
> Signed-off-by: Juan Quintela <quintela@redhat.com>
> ---
> linux-user/mmap.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/linux-user/mmap.c b/linux-user/mmap.c
> index c1c7e48..25fc0b2 100644
> --- a/linux-user/mmap.c
> +++ b/linux-user/mmap.c
> @@ -243,7 +243,7 @@ static int mmap_frag(abi_ulong real_start,
> possible while it is a shared mapping */
> if ((flags & MAP_TYPE) == MAP_SHARED &&
> (prot & PROT_WRITE))
> - return -EINVAL;
> + return -1;
>
> /* adjust protection to be able to read */
> if (!(prot1 & PROT_WRITE))
Looks good to me, but a similar patch is needed for
bsd-user/mmap.c and darwin-user/mmap.c.
Laurent
next prev parent reply other threads:[~2010-01-25 8:53 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-20 20:13 [Qemu-devel] [PATCH v2 00/17] Fix compilation with _FORTIFY_SOURCE Juan Quintela
2010-01-20 20:13 ` [Qemu-devel] [PATCH 01/17] Introduce qemu_write_full() Juan Quintela
2010-01-20 20:13 ` [Qemu-devel] [PATCH 02/17] force to test result for qemu_write_full() Juan Quintela
2010-01-20 20:13 ` [Qemu-devel] [PATCH 03/17] posix-aio-compat.c: fix warning with _FORTIFY_SOURCE Juan Quintela
2010-01-20 20:14 ` [Qemu-devel] [PATCH 04/17] block/cow.c: fix warnings " Juan Quintela
2010-01-20 20:14 ` [Qemu-devel] [PATCH 05/17] block/qcow.c: " Juan Quintela
2010-01-20 20:14 ` [Qemu-devel] [PATCH 06/17] block/vmdk.o: " Juan Quintela
2010-01-20 20:14 ` [Qemu-devel] [PATCH 07/17] block/vvfat.c: " Juan Quintela
2010-01-21 7:37 ` Gleb Natapov
2010-01-21 8:17 ` [Qemu-devel] " Juan Quintela
2010-01-21 8:18 ` Gleb Natapov
2010-01-21 9:28 ` Markus Armbruster
2010-01-20 20:14 ` [Qemu-devel] [PATCH 08/17] block/qcow2.c: " Juan Quintela
2010-01-20 20:14 ` [Qemu-devel] [PATCH 09/17] net/slirp.c: fix warning " Juan Quintela
2010-01-20 20:14 ` [Qemu-devel] [PATCH 10/17] usb-linux.c: " Juan Quintela
2010-01-20 20:14 ` [Qemu-devel] [PATCH 11/17] vl.c: " Juan Quintela
2010-01-20 20:14 ` [Qemu-devel] [PATCH 12/17] monitor.c: fix warnings " Juan Quintela
2010-01-20 20:14 ` [Qemu-devel] [PATCH 13/17] linux-user/mmap.c: " Juan Quintela
2010-01-20 20:14 ` [Qemu-devel] [PATCH 14/17] check pipe() return value Juan Quintela
2010-01-20 20:14 ` [Qemu-devel] [PATCH 15/17] Enable _FORTIFY_SOURCE=2 Juan Quintela
2010-01-20 20:14 ` [Qemu-devel] [PATCH 16/17] Check availavility of -fstack-protector-all Juan Quintela
2010-01-20 20:14 ` [Qemu-devel] [PATCH 17/17] mmap_frag() users only check for -1 error Juan Quintela
2010-01-25 8:53 ` Laurent Desnogues [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-01-19 23:56 [Qemu-devel] [PATCH 00/17] Fix compilation with _FORTIFY_SOURCE Juan Quintela
2010-01-19 23:56 ` [Qemu-devel] [PATCH 17/17] mmap_frag() users only check for -1 error Juan Quintela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=761ea48b1001250053y39d62dc7t59bcdeddeff90277@mail.gmail.com \
--to=laurent.desnogues@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).