From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NZoHn-0006mG-NJ
	for qemu-devel@nongnu.org; Tue, 26 Jan 2010 11:29:03 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NZoHj-0006hH-SE
	for qemu-devel@nongnu.org; Tue, 26 Jan 2010 11:29:03 -0500
Received: from [199.232.76.173] (port=43419 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NZoHj-0006h9-N3
	for qemu-devel@nongnu.org; Tue, 26 Jan 2010 11:28:59 -0500
Received: from mail-pw0-f43.google.com ([209.85.160.43]:61647)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <laurent.desnogues@gmail.com>) id 1NZoHj-0007Jz-6r
	for qemu-devel@nongnu.org; Tue, 26 Jan 2010 11:28:59 -0500
Received: by pwj11 with SMTP id 11so3372545pwj.2
	for <qemu-devel@nongnu.org>; Tue, 26 Jan 2010 08:28:57 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <1264521604-2020-6-git-send-email-riku.voipio@iki.fi>
References: <1264521604-2020-1-git-send-email-riku.voipio@iki.fi>
	<1264521604-2020-6-git-send-email-riku.voipio@iki.fi>
Date: Tue, 26 Jan 2010 17:28:57 +0100
Message-ID: <761ea48b1001260828p2547c20egeca08eebd99e5ea4@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH 5/5] target-arm: Thread ID Registers are
	ARMv6K +
From: Laurent Desnogues <laurent.desnogues@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Riku Voipio <riku.voipio@iki.fi>
Cc: Riku Voipio <riku.voipio@nokia.com>, qemu-devel@nongnu.org

On Tue, Jan 26, 2010 at 5:00 PM, Riku Voipio <riku.voipio@iki.fi> wrote:
> From: Riku Voipio <riku.voipio@nokia.com>
>
> Change the system-emulation code also to only support accessing
> the cp15.c13 Thread ID registers on ARMv6K and newer.
>
> Signed-off-by: Riku Voipio <riku.voipio@nokia.com>
> ---
> =A0target-arm/helper.c | =A0 12 ++++++++++++
> =A01 files changed, 12 insertions(+), 0 deletions(-)
>
> diff --git a/target-arm/helper.c b/target-arm/helper.c
> index 68578ce..1245d9d 100644
> --- a/target-arm/helper.c
> +++ b/target-arm/helper.c
> @@ -1517,12 +1517,18 @@ void HELPER(set_cp15)(CPUState *env, uint32_t ins=
n, uint32_t val)
> =A0 =A0 =A0 =A0 =A0 =A0 env->cp15.c13_context =3D val;
> =A0 =A0 =A0 =A0 =A0 =A0 break;
> =A0 =A0 =A0 =A0 case 2:
> + =A0 =A0 =A0 =A0 =A0 =A0if (!arm_feature(env, ARM_FEATURE_V6K))
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0goto bad_reg;
> =A0 =A0 =A0 =A0 =A0 =A0 env->cp15.c13_tls1 =3D val;
> =A0 =A0 =A0 =A0 =A0 =A0 break;
> =A0 =A0 =A0 =A0 case 3:
> + =A0 =A0 =A0 =A0 =A0 =A0if (!arm_feature(env, ARM_FEATURE_V6K))
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0goto bad_reg;
> =A0 =A0 =A0 =A0 =A0 =A0 env->cp15.c13_tls2 =3D val;
> =A0 =A0 =A0 =A0 =A0 =A0 break;
> =A0 =A0 =A0 =A0 case 4:
> + =A0 =A0 =A0 =A0 =A0 =A0if (!arm_feature(env, ARM_FEATURE_V6K))
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0goto bad_reg;
> =A0 =A0 =A0 =A0 =A0 =A0 env->cp15.c13_tls3 =3D val;
> =A0 =A0 =A0 =A0 =A0 =A0 break;
> =A0 =A0 =A0 =A0 default:
> @@ -1805,10 +1811,16 @@ uint32_t HELPER(get_cp15)(CPUState *env, uint32_t=
 insn)
> =A0 =A0 =A0 =A0 case 1:
> =A0 =A0 =A0 =A0 =A0 =A0 return env->cp15.c13_context;
> =A0 =A0 =A0 =A0 case 2:
> + =A0 =A0 =A0 =A0 =A0 =A0if (!arm_feature(env, ARM_FEATURE_V6K))
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0goto bad_reg;
> =A0 =A0 =A0 =A0 =A0 =A0 return env->cp15.c13_tls1;
> =A0 =A0 =A0 =A0 case 3:
> + =A0 =A0 =A0 =A0 =A0 =A0if (!arm_feature(env, ARM_FEATURE_V6K))
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0goto bad_reg;
> =A0 =A0 =A0 =A0 =A0 =A0 return env->cp15.c13_tls2;
> =A0 =A0 =A0 =A0 case 4:
> + =A0 =A0 =A0 =A0 =A0 =A0if (!arm_feature(env, ARM_FEATURE_V6K))
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0goto bad_reg;
> =A0 =A0 =A0 =A0 =A0 =A0 return env->cp15.c13_tls3;
> =A0 =A0 =A0 =A0 default:
> =A0 =A0 =A0 =A0 =A0 =A0 goto bad_reg;

Same question as for user mode :-)


Laurent