From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Ne6ZO-0007sl-Ny
	for qemu-devel@nongnu.org; Sun, 07 Feb 2010 07:48:58 -0500
Received: from [199.232.76.173] (port=58453 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Ne6ZO-0007sP-76
	for qemu-devel@nongnu.org; Sun, 07 Feb 2010 07:48:58 -0500
Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim
	4.60) (envelope-from <laurent.desnogues@gmail.com>)
	id 1Ne6ZN-00035a-Bh
	for qemu-devel@nongnu.org; Sun, 07 Feb 2010 07:48:57 -0500
Received: from mail-pz0-f187.google.com ([209.85.222.187]:43201)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <laurent.desnogues@gmail.com>) id 1Ne6ZL-00034y-09
	for qemu-devel@nongnu.org; Sun, 07 Feb 2010 07:48:56 -0500
Received: by pzk17 with SMTP id 17so1277214pzk.4
	for <qemu-devel@nongnu.org>; Sun, 07 Feb 2010 04:48:53 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <1265385151-11024-2-git-send-email-riku.voipio@iki.fi>
References: <1265385151-11024-1-git-send-email-riku.voipio@iki.fi>
	<1265385151-11024-2-git-send-email-riku.voipio@iki.fi>
Date: Sun, 7 Feb 2010 13:48:53 +0100
Message-ID: <761ea48b1002070448w6cca394ak56c0e15c35efeca1@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH 1/4] target-arm: neon - fix VRADDHN/VRSUBHN
	vs VADDHN/VSUBHN
From: Laurent Desnogues <laurent.desnogues@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Riku Voipio <riku.voipio@iki.fi>
Cc: qemu-devel@nongnu.org

On Fri, Feb 5, 2010 at 4:52 PM, Riku Voipio <riku.voipio@iki.fi> wrote:
> From: Riku Voipio <riku.voipio@nokia.com>
>
> The rounding/truncating options were inverted. truncating
> was done when rounding was meant and vice verse.
>
> Signed-off-by: Riku Voipio <riku.voipio@nokia.com>

Acked-by: Laurent Desnogues <laurent.desnogues@gmail.com>


Laurent

> ---
> =A0target-arm/translate.c | =A0 =A04 ++--
> =A01 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/target-arm/translate.c b/target-arm/translate.c
> index 5cf3e06..4bd813a 100644
> --- a/target-arm/translate.c
> +++ b/target-arm/translate.c
> @@ -4957,7 +4957,7 @@ static int disas_neon_data_insn(CPUState * env, Dis=
asContext *s, uint32_t insn)
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 case 0: case 1: case 4: /* VADDL,=
 VADDW, VADDHN, VRADDHN */
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 gen_neon_addl(size);
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 break;
> - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0case 2: case 3: case 6: /* VSUBL=
, VSUBW, VSUBHL, VRSUBHL */
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0case 2: case 3: case 6: /* VSUBL=
, VSUBW, VSUBHN, VRSUBHN */
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 gen_neon_subl(size);
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 break;
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 case 5: case 7: /* VABAL, VABDL *=
/
> @@ -5026,7 +5026,7 @@ static int disas_neon_data_insn(CPUState * env, Dis=
asContext *s, uint32_t insn)
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 } else if (op =3D=3D 4 || op =3D=
=3D 6) {
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 /* Narrowing operation. =
=A0*/
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 tmp =3D new_tmp();
> - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0if (u) {
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0if (!u) {
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 switch (size) {
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 case 0:
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 gen_helpe=
r_neon_narrow_high_u8(tmp, cpu_V0);
> --
> 1.6.5
>
>
>
>