From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Ne6bf-00007y-I0
	for qemu-devel@nongnu.org; Sun, 07 Feb 2010 07:51:19 -0500
Received: from [199.232.76.173] (port=60477 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Ne6bf-00007m-2Z
	for qemu-devel@nongnu.org; Sun, 07 Feb 2010 07:51:19 -0500
Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim
	4.60) (envelope-from <laurent.desnogues@gmail.com>)
	id 1Ne6be-0003lo-3w
	for qemu-devel@nongnu.org; Sun, 07 Feb 2010 07:51:18 -0500
Received: from mail-px0-f189.google.com ([209.85.216.189]:48208)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <laurent.desnogues@gmail.com>) id 1Ne6bd-0003l5-FA
	for qemu-devel@nongnu.org; Sun, 07 Feb 2010 07:51:17 -0500
Received: by pxi27 with SMTP id 27so2932537pxi.4
	for <qemu-devel@nongnu.org>; Sun, 07 Feb 2010 04:51:16 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <1265385151-11024-3-git-send-email-riku.voipio@iki.fi>
References: <1265385151-11024-1-git-send-email-riku.voipio@iki.fi>
	<1265385151-11024-3-git-send-email-riku.voipio@iki.fi>
Date: Sun, 7 Feb 2010 13:51:15 +0100
Message-ID: <761ea48b1002070451p1a44c7d9xef793dea83d6f98d@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH 2/4] target-arm: neon vshll instruction fix
From: Laurent Desnogues <laurent.desnogues@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Riku Voipio <riku.voipio@iki.fi>
Cc: qemu-devel@nongnu.org

On Fri, Feb 5, 2010 at 4:52 PM, Riku Voipio <riku.voipio@iki.fi> wrote:
> From: Juha Riihim=E4ki <juha.riihimaki@nokia.com>
>
> implementation only widened the 32bit source vector elements into a
> 64bit destination vector but forgot to perform the actual shifting
> operation.
>
> Signed-off-by: Juha Riihim=E4ki <juha.riihimaki@nokia.com>
> Signed-off-by: Riku Voipio <riku.voipio@nokia.com>

Acked-by: Laurent Desnogues <laurent.desnogues@gmail.com>


Laurent

> ---
> =A0target-arm/translate.c | =A0 =A01 +
> =A01 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/target-arm/translate.c b/target-arm/translate.c
> index 4bd813a..537d9d6 100644
> --- a/target-arm/translate.c
> +++ b/target-arm/translate.c
> @@ -5385,6 +5385,7 @@ static int disas_neon_data_insn(CPUState * env, Dis=
asContext *s, uint32_t insn)
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 if (pass =3D=3D 1)
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 tmp =3D tmp2;
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 gen_neon_widen(cpu_V0, tm=
p, size, 1);
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0tcg_gen_shli_i64(cpu_V0,=
 cpu_V0, 8 << size);
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 neon_store_reg64(cpu_V0, =
rd + pass);
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 }
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 break;
> --
> 1.6.5
>
>
>
>