From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7361EC433DB for ; Wed, 17 Mar 2021 11:21:17 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 21B6B64F09 for ; Wed, 17 Mar 2021 11:21:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 21B6B64F09 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:57292 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lMUEm-0005bO-AH for qemu-devel@archiver.kernel.org; Wed, 17 Mar 2021 07:21:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44570) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lMUAJ-0001yd-VX for qemu-devel@nongnu.org; Wed, 17 Mar 2021 07:16:39 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:60939) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1lMUAC-0005eQ-4o for qemu-devel@nongnu.org; Wed, 17 Mar 2021 07:16:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1615979788; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+eqGTBlFLUEeYY1BbfzlUjjWjsyELtRK6iV+LyRZcwE=; b=KDZN5H49BAsccT1Ca44t0TfVfvIeplRanWOWhtXQEaCttnMq9k9K8p6x4rwVHZRz+YC2uZ ffCyVf4A0xHXuthTZTkXR5OopmOL0jYoFRx2/pypmGaxyDwkkBrcJFo5NCTHTXwqa01W9o ZHHAklNI3IeEyKXUJn/JsFljLMpKTGU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-512-4taNxWxlMqOUtuZn2GBETQ-1; Wed, 17 Mar 2021 07:16:24 -0400 X-MC-Unique: 4taNxWxlMqOUtuZn2GBETQ-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8AE9C107ACCD; Wed, 17 Mar 2021 11:16:23 +0000 (UTC) Received: from [10.3.113.66] (ovpn-113-66.phx2.redhat.com [10.3.113.66]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8752B1045E83; Wed, 17 Mar 2021 11:16:18 +0000 (UTC) Subject: Re: [PATCH v2 1/1] utils: Use fixed-point arithmetic in qemu_strtosz To: Thomas Huth , Richard Henderson , qemu-devel@nongnu.org References: <20210315155835.1970210-1-richard.henderson@linaro.org> <20210315155835.1970210-2-richard.henderson@linaro.org> <6ebe24d3-5424-5958-7ffb-80c90a020e18@redhat.com> From: Eric Blake Organization: Red Hat, Inc. Message-ID: <762b8658-f16f-5d64-2a6e-0a69b2fbeccf@redhat.com> Date: Wed, 17 Mar 2021 06:16:11 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <6ebe24d3-5424-5958-7ffb-80c90a020e18@redhat.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=eblake@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=63.128.21.124; envelope-from=eblake@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.251, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: philmd@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 3/17/21 2:09 AM, Thomas Huth wrote: > On 15/03/2021 16.58, Richard Henderson wrote: >> Once we've parsed the fractional value, extract it into an integral >> 64-bit fraction.  Perform the scaling with integer arithemetic, and >> simplify the overflow detection. > > I've put this patch in my local branch, but I'm still getting a failure > in the cutils test, this time in the Cirrus-CI with the MinGW build: > >  https://cirrus-ci.com/task/5413753530351616?command=test#L543 > > Is it related or is this a different bug? ERROR test-cutils - Bail out! ERROR:../tests/unit/test-cutils.c:2233:test_qemu_strtosz_trailing: assertion failed (res == 0): (1024 == 0) That's testing behavior on: str = "0x"; err = qemu_strtosz(str, &endptr, &res); which should parse as "0" with a suffix of 'x'. It is an independent issue (unrelated to the rounding issues fixed in rth's patch), and rather appears to be a bug in mingw's libc for strtoull although I have not actually set up an environment to test that assumption yet. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org