From: Richard Henderson <richard.henderson@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH 2/5] target/arm: Fill in ARMISARegisters for kvm64
Date: Mon, 29 Oct 2018 16:03:19 +0000 [thread overview]
Message-ID: <762ccc95-2adf-2fc6-f2bc-8ad7d26d74a6@linaro.org> (raw)
In-Reply-To: <CAFEAcA-ft-mktP5fz=fHvWzvJtZN1m86WHWYvXKba0Bv0hqPtw@mail.gmail.com>
On 10/29/18 2:58 PM, Peter Maydell wrote:
> I think I would prefer it if we expanded the id_isar* fields
> in the ARMISARegisters struct to uint64_t. If you dislike
> that, I think we should make this code fail a bit more gracefully
> in the presence of an unexpected extension into the high bits
> of these registers. Or just ignore the high bits, since we're
> effectively trusting that future architecture versions use
> a compatible meaning for these registers anyway.
Given these options, I'd prefer to just ignore the high bits.
I'm fairly comfortable trusting that the architecture gods
won't mess up and assign values in there. Otherwise they
would have already expanded instead of adding ID_ISAR6.
r~
next prev parent reply other threads:[~2018-10-29 16:03 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-24 11:37 [Qemu-devel] [PATCH 0/5] target/arm: KVM vs ARMISARegisters Richard Henderson
2018-10-24 11:37 ` [Qemu-devel] [PATCH 1/5] target/arm: Install ARMISARegisters from kvm host Richard Henderson
2018-11-02 14:24 ` Peter Maydell
2018-10-24 11:37 ` [Qemu-devel] [PATCH 2/5] target/arm: Fill in ARMISARegisters for kvm64 Richard Henderson
2018-10-29 14:58 ` Peter Maydell
2018-10-29 16:03 ` Richard Henderson [this message]
2018-11-02 14:37 ` Peter Maydell
2018-10-24 11:37 ` [Qemu-devel] [PATCH 3/5] target/arm: Introduce read_sys_reg32 for kvm32 Richard Henderson
2018-10-24 12:49 ` Richard Henderson
2018-11-02 14:30 ` Peter Maydell
2018-11-02 14:37 ` Richard Henderson
2018-10-24 11:37 ` [Qemu-devel] [PATCH 4/5] target/arm: Fill in ARMISARegisters " Richard Henderson
2018-10-29 15:13 ` Peter Maydell
2018-10-29 15:21 ` Peter Maydell
2018-10-29 15:40 ` Marc Zyngier
2018-10-29 15:48 ` Peter Maydell
2018-10-29 15:56 ` Marc Zyngier
2018-10-24 11:37 ` [Qemu-devel] [PATCH 5/5] target/arm: Convert t32ee from feature bit to isar3 test Richard Henderson
2018-11-02 14:34 ` Peter Maydell
2018-11-01 17:26 ` [Qemu-devel] [PATCH 0/5] target/arm: KVM vs ARMISARegisters Alex Bennée
2018-11-01 17:30 ` Peter Maydell
2018-11-01 18:09 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=762ccc95-2adf-2fc6-f2bc-8ad7d26d74a6@linaro.org \
--to=richard.henderson@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).