Re: [PULL 3/3] target/mips: Separate FPU-related helpers into their own file

["Aleksandar Markovic" <Aleksandar.Markovic@rt-rk.com>]

[-- Attachment #1: Type: text/plain, Size: 1678 bytes --]


> >
> > For clarity and easier maintenence, create target/mips/fpu_helper.c, and
> > move all FPU-related content form target/mips/op_helper.c to that file.
> >
> > Signed-off-by: Aleksandar Markovic <amarkovic@wavecomp.com>
> > Reviewed-by: Aleksandar Rikalo <aleksandar.rikalo@rt-rk.com>
> > Message-Id: <1580745443-24650-3-git-send-email-aleksandar.markovic@rt-rk.com>
> > ---
> > target/mips/Makefile.objs | 2 +-
> > target/mips/fpu_helper.c | 1911 +++++++++++++++++++++++++++++++++++++++++++++
> > target/mips/op_helper.c | 1877 --------------------------------------------
> > 3 files changed, 1912 insertions(+), 1878 deletions(-)
> > create mode 100644 target/mips/fpu_helper.c
> >
> > diff --git a/target/mips/Makefile.objs b/target/mips/Makefile.objs
> > index 3ca2bde..91eb691 100644
> > --- a/target/mips/Makefile.objs
> > +++ b/target/mips/Makefile.objs
> > @@ -1,5 +1,5 @@
> > obj-y += translate.o cpu.o gdbstub.o helper.o
> > -obj-y += op_helper.o cp0_helper.o
> > +obj-y += op_helper.o cp0_helper.o fpu_helper.o
> > obj-y += dsp_helper.o lmi_helper.o msa_helper.o
> > obj-$(CONFIG_SOFTMMU) += mips-semi.o
> > obj-$(CONFIG_SOFTMMU) += machine.o cp0_timer.o
> > diff --git a/target/mips/fpu_helper.c b/target/mips/fpu_helper.c
> > new file mode 100644
> > index 0000000..0d5769e
> > --- /dev/null
> > +++ b/target/mips/fpu_helper.c
> > @@ -0,0 +1,1911 @@
> > +/*
> > + * Helpers for emulation of CP0-related MIPS instructions.
>
> Isn't it "FPU"?
>

Damn, I did the change, but forgot to do "commit --amend", and that passed unnoticed during the rest of procedure.

I just sent PULL v2.

Thanks, Philippe.

Aleksandar

[-- Attachment #2: Type: text/html, Size: 2116 bytes --]