qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Fiona Ebner <f.ebner@proxmox.com>
To: John Snow <jsnow@redhat.com>, Niklas Cassel <niklas.cassel@wdc.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org,
	Simon Rowe <simon.rowe@nutanix.com>,
	Felipe Franciosi <felipe@nutanix.com>
Subject: Re: [PATCH 1/1] hw/ide/core: terminate in-flight DMA on IDE bus reset
Date: Tue, 26 Sep 2023 09:11:41 +0200	[thread overview]
Message-ID: <7658d927-1d05-8f2d-9739-d1db692bee72@proxmox.com> (raw)
In-Reply-To: <CAFn=p-YL_hmnrFY9hhuMgMkV4hL3dojMMWUdG9=DBGYuxi_TUw@mail.gmail.com>

Am 25.09.23 um 21:53 schrieb John Snow:
> On Thu, Sep 21, 2023 at 12:07 PM Simon Rowe <simon.rowe@nutanix.com> wrote:
>>
>> When an IDE controller is reset, its internal state is being cleared
>> before any outstanding I/O is cancelled. If a response to DMA is
>> received in this window, the aio callback will incorrectly continue
>> with the next part of the transfer (now using sector 0 from
>> the cleared controller state).
> 
> Eugh, yikes. It feels like we should fix the cancellation ... 
Please note that there already is a patch for that on the list:
https://lists.nongnu.org/archive/html/qemu-devel/2023-09/msg01011.html

Best Regards,
Fiona



  reply	other threads:[~2023-09-26  7:13 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-21 16:07 [PATCH 0/1] CVE-2023-5088 Simon Rowe
2023-09-21 16:07 ` [PATCH 1/1] hw/ide/core: terminate in-flight DMA on IDE bus reset Simon Rowe
2023-09-25 19:53   ` John Snow
2023-09-26  7:11     ` Fiona Ebner [this message]
2023-09-26 14:45       ` John Snow
2023-09-28 11:23         ` Fiona Ebner
2023-10-02  9:08           ` Simon Rowe
2023-10-02 22:59             ` John Snow
2023-10-03 12:46               ` Simon Rowe
2023-10-03 14:06     ` Niklas Cassel
2023-10-03 17:05       ` John Snow
2023-10-04  7:51         ` Simon Rowe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7658d927-1d05-8f2d-9739-d1db692bee72@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=felipe@nutanix.com \
    --cc=jsnow@redhat.com \
    --cc=niklas.cassel@wdc.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=simon.rowe@nutanix.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).