From: Richard Henderson <richard.henderson@linaro.org>
To: "Alex Bennée" <alex.bennee@linaro.org>, qemu-devel@nongnu.org
Cc: "Riku Voipio" <riku.voipio@iki.fi>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Laurent Vivier" <laurent@vivier.eu>
Subject: Re: [PATCH v1 6/9] gdbstub/linux-user: support debugging over a unix socket
Date: Fri, 1 May 2020 07:43:01 -0700 [thread overview]
Message-ID: <765cad43-990b-c4e8-d786-6adbf28dbca6@linaro.org> (raw)
In-Reply-To: <20200430190122.4592-7-alex.bennee@linaro.org>
On 4/30/20 12:01 PM, Alex Bennée wrote:
> @@ -814,7 +814,7 @@ int main(int argc, char **argv)
> exit(1);
> }
> } else if (!strcmp(r, "g")) {
> - gdbstub_port = atoi(argv[optind++]);
> + gdbstub = g_strdup(argv[optind++]);
You've got one too many strdup.
The one here in bsd-user main, and a similar one in linux-user handle_arg_gdb,
are redundant with...
> + gdbserver_state.socket_path = g_strdup(port_or_path);
... this one, in gdbserver_start.
Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2020-05-01 14:45 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-30 19:01 [PATCH v1 0/9] gdbstub/next Alex Bennée
2020-04-30 19:01 ` [PATCH v1 1/9] configure: favour gdb-multiarch if we have it Alex Bennée
2020-05-01 12:25 ` Philippe Mathieu-Daudé
2020-05-01 13:22 ` Alex Bennée
2020-04-30 19:01 ` [PATCH v1 2/9] gdbstub: Introduce gdb_get_float64() to get 64-bit float registers Alex Bennée
2020-05-01 14:34 ` Richard Henderson
2020-04-30 19:01 ` [PATCH v1 3/9] tests/tcg: better trap gdb failures Alex Bennée
2020-04-30 19:01 ` [PATCH v1 4/9] tests/tcg: drop inferior.was_attached() test Alex Bennée
2020-04-30 19:01 ` [PATCH v1 5/9] gdbstub: eliminate gdbserver_fd global Alex Bennée
2020-05-01 12:28 ` Philippe Mathieu-Daudé
2020-05-01 14:35 ` Richard Henderson
2020-04-30 19:01 ` [PATCH v1 6/9] gdbstub/linux-user: support debugging over a unix socket Alex Bennée
2020-05-01 14:43 ` Richard Henderson [this message]
2020-04-30 19:01 ` [PATCH v1 7/9] tests/guest-debug: use the unix socket for linux-user tests Alex Bennée
2020-05-01 14:46 ` Richard Henderson
2020-05-01 14:59 ` Alex Bennée
2020-04-30 19:01 ` [PATCH v1 8/9] tests/tcg: add a multiarch linux-user gdb test Alex Bennée
2020-05-01 14:47 ` Richard Henderson
2020-04-30 19:01 ` [PATCH v1 9/9] target/m68k: fix gdb for m68xxx Alex Bennée
2020-05-01 14:45 ` Richard Henderson
2020-05-01 14:46 ` Laurent Vivier
2020-05-01 7:01 ` [PATCH v1 0/9] gdbstub/next no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=765cad43-990b-c4e8-d786-6adbf28dbca6@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=laurent@vivier.eu \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).