From: Richard Henderson <richard.henderson@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Mostafa Saleh <smostafa@google.com>,
qemu-devel@nongnu.org, jean-philippe@linaro.org,
eric.auger@redhat.com, qemu-arm@nongnu.org
Subject: Re: [PATCH v4] hw/arm/smmuv3: Add GBPA register
Date: Mon, 13 Feb 2023 09:45:33 -1000 [thread overview]
Message-ID: <76616dd5-567c-c0fa-118c-0a4f06d4fb2d@linaro.org> (raw)
In-Reply-To: <CAFEAcA9iBui4zHCo+4b6o6rTXgQ=VpNzWUUTZmv_CR=cxWV3gw@mail.gmail.com>
On 2/13/23 00:57, Peter Maydell wrote:
> On Sat, 11 Feb 2023 at 23:49, Richard Henderson
> <richard.henderson@linaro.org> wrote:
>>
>> On 2/10/23 12:19, Mostafa Saleh wrote:
>>> @@ -1512,6 +1553,10 @@ static const VMStateDescription vmstate_smmuv3 = {
>>>
>>> VMSTATE_END_OF_LIST(),
>>> },
>>> + .subsections = (const VMStateDescription * []) {
>>> + &vmstate_gbpa,
>>> + NULL
>>> + }
>>
>> Actually, I suspect that you need a pre_load hook that resets gbpa, which will then be
>> overwritten if and only if the saved value != reset value.
>
> VM loads are guaranteed to start from a VM state which is freshly
> reset, so the device's reset method is sufficient for this.
Thanks for the confirmation.
r~
prev parent reply other threads:[~2023-02-13 19:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-10 22:19 [PATCH v4] hw/arm/smmuv3: Add GBPA register Mostafa Saleh
2023-02-11 23:34 ` Richard Henderson
2023-02-13 16:49 ` Eric Auger
2023-02-11 23:48 ` Richard Henderson
2023-02-12 13:23 ` Mostafa Saleh
2023-02-12 15:18 ` Richard Henderson
2023-02-12 22:20 ` Mostafa Saleh
2023-02-13 10:57 ` Peter Maydell
2023-02-13 19:45 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=76616dd5-567c-c0fa-118c-0a4f06d4fb2d@linaro.org \
--to=richard.henderson@linaro.org \
--cc=eric.auger@redhat.com \
--cc=jean-philippe@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=smostafa@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).