From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E1D13C5478A for ; Wed, 21 Feb 2024 19:14:36 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rcs22-0004Hz-34; Wed, 21 Feb 2024 14:13:26 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rcs1q-0004FW-2f for qemu-devel@nongnu.org; Wed, 21 Feb 2024 14:13:14 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rcs1o-0004NA-AD for qemu-devel@nongnu.org; Wed, 21 Feb 2024 14:13:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1708542791; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=qbTENkWGaV8erFoIMgito9H09VnVthMe5ladi3wIndQ=; b=eTpVjpC4qrvk0u+hi3WdS9vyP9QNuT/atBHbLLV1/SmNUYAY7IpjYYeNGe/HV/5gSUGds7 gqMY/en9LWfBDEQdxE/uQO9KniMR8MgYt2yXiNX1Mxi49YqAhP6GxEOlQvedK1hkvvwTpn 5Q2D5triN/Mdixh0gW8R7W431sy9ocY= Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-624-Exdl6KU3PvmZuoWuDm__5w-1; Wed, 21 Feb 2024 14:13:09 -0500 X-MC-Unique: Exdl6KU3PvmZuoWuDm__5w-1 Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-42dc8c2e9bfso53689011cf.0 for ; Wed, 21 Feb 2024 11:13:09 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708542789; x=1709147589; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=qbTENkWGaV8erFoIMgito9H09VnVthMe5ladi3wIndQ=; b=b6rFqFO0JbfndnBf1HLi5cfyY6wt/bkznxV2d+IiRiVZIrxh51piYa5Jyhl3lvDga5 EPF9+Kkarokfjl3PR64o66VT68V1+UuZAwuUApgb1bTwkw0QA5HkzMwokzBBvBpFehup k2UVdUItbs18ngoQ3xTY43SX2X7XUhOI51omPCGN730xEIgpUcYMAAV7gqnWfu0vFrmj O+DZeeI6YXtma3bBEdvaOEhNl/kD6lbwCpCg79btx7iIVyg6ip+iMjQ5xEK6eCmXfCai at3ATF7XtLmeRzvIvJO44iJzIiZtTmOUhTshn3Pv9eqy6hoVs9Tv891kI7ymYqH8Jsan RkxQ== X-Forwarded-Encrypted: i=1; AJvYcCUWFj8S67AEt9UzhYmfZHP1mdxHOMmqfQ4ySiwaEZqYeCn8Q8JnZS94id3/11ulBAZnkp39jAD4a4w3uHOkann6BUhM14A= X-Gm-Message-State: AOJu0YxSTBiyA3M7sUSdaMPZnztDI8HYSCPk+xqaMGb1JchXKHKDaAay Ey3iQ2Sl0o2WpA0QIalPikLqWzX5xemTjmW1+xzfwNMOlOlLqbJ1pjldDUVF5pcM4VARVy/IW3n UJA7FW7cRybB6Bw7LfCZHuV/fp9xgP6xirTP10W75DWF5UJuujJi7 X-Received: by 2002:a05:622a:1489:b0:42c:6fb1:1e79 with SMTP id t9-20020a05622a148900b0042c6fb11e79mr23476207qtx.13.1708542789331; Wed, 21 Feb 2024 11:13:09 -0800 (PST) X-Google-Smtp-Source: AGHT+IFaMIPWGcZL+eeU/+A+8IJGffYyanBxkTVWbo4qBMTIO8FDAeRCwMZ71EzjeMBEvQgDyhl6zQ== X-Received: by 2002:a05:622a:1489:b0:42c:6fb1:1e79 with SMTP id t9-20020a05622a148900b0042c6fb11e79mr23476184qtx.13.1708542789001; Wed, 21 Feb 2024 11:13:09 -0800 (PST) Received: from [192.168.0.9] (ip-109-43-178-100.web.vodafone.de. [109.43.178.100]) by smtp.gmail.com with ESMTPSA id l14-20020a05622a050e00b0042dfa55a3d5sm4077945qtx.25.2024.02.21.11.13.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 Feb 2024 11:13:08 -0800 (PST) Message-ID: <767097cd-06f5-4eec-a778-94b60f947e2b@redhat.com> Date: Wed, 21 Feb 2024 20:13:03 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 4/7] hw/ide: Move IDE device related definitions to ide-dev.h To: =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= , John Snow , qemu-devel@nongnu.org Cc: BALATON Zoltan , qemu-block@nongnu.org References: <20240220085505.30255-1-thuth@redhat.com> <20240220085505.30255-5-thuth@redhat.com> Content-Language: en-US From: Thomas Huth Autocrypt: addr=thuth@redhat.com; keydata= xsFNBFH7eUwBEACzyOXKU+5Pcs6wNpKzrlJwzRl3VGZt95VCdb+FgoU9g11m7FWcOafrVRwU yYkTm9+7zBUc0sW5AuPGR/dp3pSLX/yFWsA/UB4nJsHqgDvDU7BImSeiTrnpMOTXb7Arw2a2 4CflIyFqjCpfDM4MuTmzTjXq4Uov1giGE9X6viNo1pxyEpd7PanlKNnf4PqEQp06X4IgUacW tSGj6Gcns1bCuHV8OPWLkf4hkRnu8hdL6i60Yxz4E6TqlrpxsfYwLXgEeswPHOA6Mn4Cso9O 0lewVYfFfsmokfAVMKWzOl1Sr0KGI5T9CpmRfAiSHpthhHWnECcJFwl72NTi6kUcUzG4se81 O6n9d/kTj7pzTmBdfwuOZ0YUSqcqs0W+l1NcASSYZQaDoD3/SLk+nqVeCBB4OnYOGhgmIHNW 0CwMRO/GK+20alxzk//V9GmIM2ACElbfF8+Uug3pqiHkVnKqM7W9/S1NH2qmxB6zMiJUHlTH gnVeZX0dgH27mzstcF786uPcdEqS0KJuxh2kk5IvUSL3Qn3ZgmgdxBMyCPciD/1cb7/Ahazr 3ThHQXSHXkH/aDXdfLsKVuwDzHLVSkdSnZdt5HHh75/NFHxwaTlydgfHmFFwodK8y/TjyiGZ zg2Kje38xnz8zKn9iesFBCcONXS7txENTzX0z80WKBhK+XSFJwARAQABzR5UaG9tYXMgSHV0 aCA8dGh1dGhAcmVkaGF0LmNvbT7CwXgEEwECACIFAlVgX6oCGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAAoJEC7Z13T+cC21EbIP/ii9cvT2HHGbFRl8HqGT6+7Wkb+XLMqJBMAIGiQK QIP3xk1HPTsLfVG0ao4hy/oYkGNOP8+ubLnZen6Yq3zAFiMhQ44lvgigDYJo3Ve59gfe99KX EbtB+X95ODARkq0McR6OAsPNJ7gpEUzfkQUUJTXRDQXfG/FX303Gvk+YU0spm2tsIKPl6AmV 1CegDljzjycyfJbk418MQmMu2T82kjrkEofUO2a24ed3VGC0/Uz//XCR2ZTo+vBoBUQl41BD eFFtoCSrzo3yPFS+w5fkH9NT8ChdpSlbNS32NhYQhJtr9zjWyFRf0Zk+T/1P7ECn6gTEkp5k ofFIA4MFBc/fXbaDRtBmPB0N9pqTFApIUI4vuFPPO0JDrII9dLwZ6lO9EKiwuVlvr1wwzsgq zJTPBU3qHaUO4d/8G+gD7AL/6T4zi8Jo/GmjBsnYaTzbm94lf0CjXjsOX3seMhaE6WAZOQQG tZHAO1kAPWpaxne+wtgMKthyPLNwelLf+xzGvrIKvLX6QuLoWMnWldu22z2ICVnLQChlR9d6 WW8QFEpo/FK7omuS8KvvopFcOOdlbFMM8Y/8vBgVMSsK6fsYUhruny/PahprPbYGiNIhKqz7 UvgyZVl4pBFjTaz/SbimTk210vIlkDyy1WuS8Zsn0htv4+jQPgo9rqFE4mipJjy/iboDzsFN BFH7eUwBEAC2nzfUeeI8dv0C4qrfCPze6NkryUflEut9WwHhfXCLjtvCjnoGqFelH/PE9NF4 4VPSCdvD1SSmFVzu6T9qWdcwMSaC+e7G/z0/AhBfqTeosAF5XvKQlAb9ZPkdDr7YN0a1XDfa +NgA+JZB4ROyBZFFAwNHT+HCnyzy0v9Sh3BgJJwfpXHH2l3LfncvV8rgFv0bvdr70U+On2XH 5bApOyW1WpIG5KPJlDdzcQTyptOJ1dnEHfwnABEfzI3dNf63rlxsGouX/NFRRRNqkdClQR3K gCwciaXfZ7ir7fF0u1N2UuLsWA8Ei1JrNypk+MRxhbvdQC4tyZCZ8mVDk+QOK6pyK2f4rMf/ WmqxNTtAVmNuZIwnJdjRMMSs4W4w6N/bRvpqtykSqx7VXcgqtv6eqoDZrNuhGbekQA0sAnCJ VPArerAZGArm63o39me/bRUQeQVSxEBmg66yshF9HkcUPGVeC4B0TPwz+HFcVhheo6hoJjLq knFOPLRj+0h+ZL+D0GenyqD3CyuyeTT5dGcNU9qT74bdSr20k/CklvI7S9yoQje8BeQAHtdV cvO8XCLrpGuw9SgOS7OP5oI26a0548M4KldAY+kqX6XVphEw3/6U1KTf7WxW5zYLTtadjISB X9xsRWSU+Yqs3C7oN5TIPSoj9tXMoxZkCIHWvnqGwZ7JhwARAQABwsFfBBgBAgAJBQJR+3lM AhsMAAoJEC7Z13T+cC21hPAQAIsBL9MdGpdEpvXs9CYrBkd6tS9mbaSWj6XBDfA1AEdQkBOn ZH1Qt7HJesk+qNSnLv6+jP4VwqK5AFMrKJ6IjE7jqgzGxtcZnvSjeDGPF1h2CKZQPpTw890k fy18AvgFHkVk2Oylyexw3aOBsXg6ukN44vIFqPoc+YSU0+0QIdYJp/XFsgWxnFIMYwDpxSHS 5fdDxUjsk3UBHZx+IhFjs2siVZi5wnHIqM7eK9abr2cK2weInTBwXwqVWjsXZ4tq5+jQrwDK cvxIcwXdUTLGxc4/Z/VRH1PZSvfQxdxMGmNTGaXVNfdFZjm4fz0mz+OUi6AHC4CZpwnsliGV ODqwX8Y1zic9viSTbKS01ZNp175POyWViUk9qisPZB7ypfSIVSEULrL347qY/hm9ahhqmn17 Ng255syASv3ehvX7iwWDfzXbA0/TVaqwa1YIkec+/8miicV0zMP9siRcYQkyTqSzaTFBBmqD oiT+z+/E59qj/EKfyce3sbC9XLjXv3mHMrq1tKX4G7IJGnS989E/fg6crv6NHae9Ckm7+lSs IQu4bBP2GxiRQ+NV3iV/KU3ebMRzqIC//DCOxzQNFNJAKldPe/bKZMCxEqtVoRkuJtNdp/5a yXFZ6TfE1hGKrDBYAm4vrnZ4CXFSBDllL59cFFOJCkn4Xboj/aVxxJxF30bn In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.05, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 21/02/2024 19.43, Philippe Mathieu-Daudé wrote: > On 20/2/24 09:55, Thomas Huth wrote: >> Unentangle internal.h by moving public IDE device related > > Disentangle ... from? Untangle? TIL Unentangle. You're right, "disentangle" seems to be the more appropriate word. I'll fix it up. > Anyway I'm not a native English speaker, so: > Reviewed-by: Philippe Mathieu-Daudé Thanks! Thomas