Re: [PATCH 1/4] fuzz: build without AddressSanitizer, by default

[Thomas Huth <thuth@redhat.com>]

On 06/07/2020 21.55, Alexander Bulekov wrote:
> We already have a nice --enable-sanitizers option to enable
> AddressSanitizer. There is no reason to duplicate and force this
> functionality in --enable-fuzzing. In the future, if more sanitizers are
> added to --enable-sanitizers, it might be impossible to build with both
> --enable-sanitizers and --enable-fuzzing, since not all sanitizers are
> compatible with libFuzzer. In that case, we could enable ASAN with
> --extra-cflags="-fsanitize=address"
> 
> Signed-off-by: Alexander Bulekov <alxndr@bu.edu>
> ---
>  configure | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/configure b/configure
> index 8a65240d4a..010c0ca479 100755
> --- a/configure
> +++ b/configure
> @@ -6319,7 +6319,7 @@ fi
>  # checks for fuzzer
>  if test "$fuzzing" = "yes" ; then
>    write_c_fuzzer_skeleton
> -  if compile_prog "$CPU_CFLAGS -Werror -fsanitize=address,fuzzer" ""; then
> +  if compile_prog "$CPU_CFLAGS -Werror -fsanitize=fuzzer" ""; then
>        have_fuzzer=yes
>    fi
>  fi
> @@ -7858,11 +7858,11 @@ if test "$sheepdog" = "yes" ; then
>  fi
>  if test "$fuzzing" = "yes" ; then
>    if test "$have_fuzzer" = "yes"; then
> -    FUZZ_LDFLAGS=" -fsanitize=address,fuzzer"
> -    FUZZ_CFLAGS=" -fsanitize=address,fuzzer"
> -    CFLAGS=" -fsanitize=address,fuzzer-no-link"
> +    FUZZ_LDFLAGS=" -fsanitize=fuzzer"
> +    FUZZ_CFLAGS=" -fsanitize=fuzzer"
> +    CFLAGS=" -fsanitize=fuzzer-no-link"
>    else
> -    error_exit "Your compiler doesn't support -fsanitize=address,fuzzer"
> +    error_exit "Your compiler doesn't support -fsanitize=fuzzer"
>      exit 1
>    fi
>  fi
> 

Reviewed-by: Thomas Huth <thuth@redhat.com>

I can add the missing $CFLAGS from commit 0ab6c2384ccae89 when picking
up the patch.

 Thomas