From: Wainer dos Santos Moschetta <wainersm@redhat.com>
To: John Snow <jsnow@redhat.com>, qemu-devel@nongnu.org
Cc: "Thomas Huth" <thuth@redhat.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Willian Rampazzo" <willianr@redhat.com>,
"Cleber Rosa" <crosa@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>
Subject: Re: [PATCH 07/11] python: update help text for check-tox
Date: Mon, 28 Jun 2021 18:16:04 -0300 [thread overview]
Message-ID: <76b9d2ac-75f8-faa7-6198-16f5294004e9@redhat.com> (raw)
In-Reply-To: <20210625154540.783306-8-jsnow@redhat.com>
Hi,
On 6/25/21 12:45 PM, John Snow wrote:
> Move it up near the check-pipenv help text, and update it to suggest parity.
>
> (At the time I first added it, I wasn't sure if I would be keeping it,
> but I've come to appreciate it as it has actually helped uncover bugs I
> would not have noticed without it. It should stay.)
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
> python/Makefile | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/python/Makefile b/python/Makefile
> index 07ad73ccd0..5cb8378b81 100644
> --- a/python/Makefile
> +++ b/python/Makefile
> @@ -9,13 +9,17 @@ help:
> @echo " Requires: Python 3.6 and pipenv."
> @echo " Hint (Fedora): 'sudo dnf install python3.6 pipenv'"
> @echo ""
> + @echo "make check-tox:"
> + @echo " Run tests against multiple python versions."
> + @echo " These tests use the newest dependencies."
> + @echo " Requires: Python 3.6-3.10 and tox."
Nit: I'm not sure it is clear '3.6-3.10' is a range rather than a
specific version.
- Wainer
> + @echo " Hint (Fedora): 'sudo dnf install python3-tox python3.10'"
> + @echo ""
> @echo "make develop: Install deps for 'make check', and"
> @echo " the qemu libs in editable/development mode."
> @echo ""
> @echo "make check: run linters using the current environment."
> @echo ""
> - @echo "make check-tox: run linters using multiple python versions."
> - @echo ""
> @echo "make pipenv"
> @echo " Creates pipenv's virtual environment (.venv)"
> @echo ""
next prev parent reply other threads:[~2021-06-28 21:17 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-25 15:45 [PATCH 00/11] Python: packaging cleanups John Snow
2021-06-25 15:45 ` [PATCH 01/11] python: expose typing information via PEP 561 John Snow
2021-06-25 18:16 ` Willian Rampazzo
2021-06-28 20:11 ` Wainer dos Santos Moschetta
2021-06-28 20:28 ` John Snow
2021-06-25 15:45 ` [PATCH 02/11] python: Remove global pylint suppressions John Snow
2021-06-25 18:18 ` Willian Rampazzo
2021-06-28 20:14 ` Wainer dos Santos Moschetta
2021-06-25 15:45 ` [PATCH 03/11] python: Re-lock pipenv at *oldest* supported versions John Snow
2021-06-25 18:28 ` Willian Rampazzo
2021-06-28 20:30 ` Wainer dos Santos Moschetta
2021-06-28 20:38 ` John Snow
2021-06-29 16:44 ` Wainer dos Santos Moschetta
2021-06-25 15:45 ` [PATCH 04/11] python: README.rst touchups John Snow
2021-06-25 18:23 ` Willian Rampazzo
2021-06-25 18:26 ` John Snow
2021-06-28 20:35 ` Wainer dos Santos Moschetta
2021-06-25 15:45 ` [PATCH 05/11] python: Add no-install usage instructions John Snow
2021-06-25 18:25 ` Willian Rampazzo
2021-06-28 20:56 ` Wainer dos Santos Moschetta
2021-06-25 15:45 ` [PATCH 06/11] python: rename 'venv-check' target to 'check-pipenv' John Snow
2021-06-25 18:27 ` Willian Rampazzo
2021-06-28 21:09 ` Wainer dos Santos Moschetta
2021-06-25 15:45 ` [PATCH 07/11] python: update help text for check-tox John Snow
2021-06-25 18:29 ` Willian Rampazzo
2021-06-28 21:16 ` Wainer dos Santos Moschetta [this message]
2021-06-29 15:40 ` John Snow
2021-06-29 16:45 ` Wainer dos Santos Moschetta
2021-06-25 15:45 ` [PATCH 08/11] python: add 'make check-venv' invocation John Snow
2021-06-25 18:36 ` Willian Rampazzo
2021-06-25 18:38 ` John Snow
2021-06-25 19:01 ` Willian Rampazzo
2021-06-25 19:12 ` John Snow
2021-06-28 21:40 ` Wainer dos Santos Moschetta
2021-06-29 15:45 ` John Snow
2021-06-25 15:45 ` [PATCH 09/11] python: Update help text on 'make check', 'make develop' John Snow
2021-06-25 18:37 ` Willian Rampazzo
2021-06-28 21:41 ` Wainer dos Santos Moschetta
2021-06-25 15:45 ` [PATCH 10/11] python: Update help text on 'make clean', 'make distclean' John Snow
2021-06-25 18:37 ` Willian Rampazzo
2021-06-28 21:44 ` Wainer dos Santos Moschetta
2021-06-25 15:45 ` [PATCH 11/11] python: remove auto-generated pyproject.toml file John Snow
2021-06-25 18:40 ` Willian Rampazzo
2021-06-28 21:48 ` Wainer dos Santos Moschetta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=76b9d2ac-75f8-faa7-6198-16f5294004e9@redhat.com \
--to=wainersm@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=crosa@redhat.com \
--cc=ehabkost@redhat.com \
--cc=f4bug@amsat.org \
--cc=jsnow@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
--cc=willianr@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).