From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org, Anton Johansson <anjo@rev.ng>
Cc: Richard Henderson <richard.henderson@linaro.org>,
Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
Subject: Re: [PATCH] target/tricore/helper: Use correct string format in cpu_tlb_fill()
Date: Tue, 19 Mar 2024 07:30:17 +0100 [thread overview]
Message-ID: <76beabbc-e4e2-419d-b647-7d6aa8983c6c@linaro.org> (raw)
In-Reply-To: <20240319051413.6956-1-philmd@linaro.org>
+Anton
On 19/3/24 06:14, Philippe Mathieu-Daudé wrote:
> 'address' got converted from target_ulong to vaddr in commit
> 68d6eee73c ("target/tricore: Convert to CPUClass::tlb_fill").
> Use the corresponding format string to avoid casting.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> target/tricore/helper.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/target/tricore/helper.c b/target/tricore/helper.c
> index 6d9e80cc0c..76bd226370 100644
> --- a/target/tricore/helper.c
> +++ b/target/tricore/helper.c
> @@ -76,9 +76,9 @@ bool tricore_cpu_tlb_fill(CPUState *cs, vaddr address, int size,
> ret = get_physical_address(env, &physical, &prot,
> address, rw, mmu_idx);
>
> - qemu_log_mask(CPU_LOG_MMU, "%s address=" TARGET_FMT_lx " ret %d physical "
> + qemu_log_mask(CPU_LOG_MMU, "%s address=0x%" VADDR_PRIx " ret %d physical "
> HWADDR_FMT_plx " prot %d\n",
> - __func__, (target_ulong)address, ret, physical, prot);
> + __func__, address, ret, physical, prot);
>
> if (ret == TLBRET_MATCH) {
> tlb_set_page(cs, address & TARGET_PAGE_MASK,
next prev parent reply other threads:[~2024-03-19 6:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-19 5:14 [PATCH] target/tricore/helper: Use correct string format in cpu_tlb_fill() Philippe Mathieu-Daudé
2024-03-19 6:30 ` Philippe Mathieu-Daudé [this message]
2024-03-19 15:40 ` Richard Henderson
2024-03-24 9:43 ` Bastian Koppelmann
2024-03-26 9:58 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=76beabbc-e4e2-419d-b647-7d6aa8983c6c@linaro.org \
--to=philmd@linaro.org \
--cc=anjo@rev.ng \
--cc=kbastian@mail.uni-paderborn.de \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).