qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Garth Dahlstrom <ironstorm@gmail.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] Andrew Curtis' PCNet Patch built on MingW
Date: Wed, 11 Aug 2004 08:17:40 -0400	[thread overview]
Message-ID: <76bfb9d2040811051758d52cce@mail.gmail.com> (raw)
In-Reply-To: <-3725715442654674811@unknownmsgid>

Antony T Curtis wrote:

> There is no such SWSTYLE as 0x04 on the PC-Net chip I emulated. You
> should be able to safely ignore this message.
>
> maybe the PACKED name conflicts with some existing symbol if you are
> having to undef it... Can you find what the original definition of it
> is? And perhaps I should call it PCN_PACKED maybe...

I'm just taking a guess that's the cause, PACKED is defined in
/includes/windef.h as the following:
#ifdef __GNUC__
#define PACKED __attribute__((packed))

The line in pcnet.h:
#define PACKED(A) A __attribute__ ((packed))
throws a PACKED redefined warning if I leave it as is... 

So in http://www.northern.ca/projects/qemu/qemu-0.6.0-mingw-pcnet-no_dhcp.zip
I did:
#ifdef __GNUC__
  #ifdef __MINGW32__ //GED
    #undef PACKED
  #endif
  #define PACKED(A) A __attribute__ ((packed))
#else
  #error FixMe
#endif

which gets rid of the warnings, but may also break the code.
 
-- 
Northern.CA ===--
http://www.northern.ca/
Canada's Search Engine

       reply	other threads:[~2004-08-11 12:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <-3725715442654674811@unknownmsgid>
2004-08-11 12:17 ` Garth Dahlstrom [this message]
2004-08-11 13:03   ` [Qemu-devel] Andrew Curtis' PCNet Patch built on MingW Antony T Curtis
2004-08-11  4:03 Garth Dahlstrom
2004-08-11  9:32 ` Antony T Curtis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=76bfb9d2040811051758d52cce@mail.gmail.com \
    --to=ironstorm@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).