From: Eric Blake <eblake@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
Stefan Hajnoczi <stefanha@redhat.com>
Cc: fam@euphon.net, kwolf@redhat.com, ehabkost@redhat.com,
qemu-block@nongnu.org, qemu-devel@nongnu.org, mreitz@redhat.com,
Paolo Bonzini <pbonzini@redhat.com>,
crosa@redhat.com, den@openvz.org
Subject: Re: [PATCH v7 0/7] coroutines: generate wrapper code
Date: Wed, 19 Aug 2020 20:33:38 -0500 [thread overview]
Message-ID: <76c463e6-0d63-d25d-8095-e87db97c5081@redhat.com> (raw)
In-Reply-To: <c610e7b2-9c1a-30fd-4217-e1bcb812ec7c@virtuozzo.com>
On 7/27/20 7:59 AM, Vladimir Sementsov-Ogievskiy wrote:
> 27.07.2020 15:48, Stefan Hajnoczi wrote:
>> On Wed, Jun 10, 2020 at 01:03:29PM +0300, Vladimir Sementsov-Ogievskiy
>> wrote:
>>> Hi all!
>>>
>>> The aim of the series is to reduce code-duplication and writing
>>> parameters structure-packing by hand around coroutine function wrappers.
>>>
>>> Benefits:
>>> Â - no code duplication
>>> Â - less indirection
>>
>> Please add documentation so others know when and how to use this.
>>
>> I suggest adding a docs/devel/coroutine-wrapper.rst document and adding
>> a code comment to #define generated_co_wrapper pointing to the
>> documentation.
>>
>> Please rename coroutine-wrapper.py to block-coroutine-wrapper.py since
>> it is specific to the block layer.
>>
>
> OK, will do. Thanks for taking a look!
As this series touched Makefile to add a generated .c, you'll also need
to rebase that part to apply on top of Paolo's meson conversion (cc'ing
him if you need help figuring it out)
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2020-08-20 1:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-10 10:03 [PATCH v7 0/7] coroutines: generate wrapper code Vladimir Sementsov-Ogievskiy
2020-06-10 10:03 ` [PATCH v7 1/7] block: return error-code from bdrv_invalidate_cache Vladimir Sementsov-Ogievskiy
2020-06-10 10:03 ` [PATCH v7 2/7] block/io: refactor coroutine wrappers Vladimir Sementsov-Ogievskiy
2020-06-10 10:03 ` [PATCH v7 3/7] block: declare some coroutine functions in block/coroutines.h Vladimir Sementsov-Ogievskiy
2020-06-10 10:03 ` [PATCH v7 4/7] scripts: add coroutine-wrapper.py Vladimir Sementsov-Ogievskiy
2020-08-20 7:38 ` Paolo Bonzini
2020-06-10 10:03 ` [PATCH v7 5/7] block: generate coroutine-wrapper code Vladimir Sementsov-Ogievskiy
2020-06-10 10:03 ` [PATCH v7 6/7] block: drop bdrv_prwv Vladimir Sementsov-Ogievskiy
2020-06-10 10:03 ` [PATCH v7 7/7] block/io: refactor save/load vmstate Vladimir Sementsov-Ogievskiy
2020-07-27 12:48 ` [PATCH v7 0/7] coroutines: generate wrapper code Stefan Hajnoczi
2020-07-27 12:59 ` Vladimir Sementsov-Ogievskiy
2020-08-20 1:33 ` Eric Blake [this message]
2020-08-20 7:34 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=76c463e6-0d63-d25d-8095-e87db97c5081@redhat.com \
--to=eblake@redhat.com \
--cc=crosa@redhat.com \
--cc=den@openvz.org \
--cc=ehabkost@redhat.com \
--cc=fam@euphon.net \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).