From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6619DC433B4 for ; Sun, 18 Apr 2021 20:21:34 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F30796024A for ; Sun, 18 Apr 2021 20:21:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F30796024A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=amsat.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:58390 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lYDvB-0003Gy-2Z for qemu-devel@archiver.kernel.org; Sun, 18 Apr 2021 16:21:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50282) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lYDuR-0002U8-9P for qemu-devel@nongnu.org; Sun, 18 Apr 2021 16:20:47 -0400 Received: from mail-wr1-x42e.google.com ([2a00:1450:4864:20::42e]:44877) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lYDuP-00017W-NZ for qemu-devel@nongnu.org; Sun, 18 Apr 2021 16:20:47 -0400 Received: by mail-wr1-x42e.google.com with SMTP id e7so22877286wrs.11 for ; Sun, 18 Apr 2021 13:20:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=2YoAYXpLUj0mTF7ivQjLncWpRXjl5q0TuUTp6E2oybw=; b=X3ziybwXEdcjLAIbw1nVMNlD3ZRokvBPcC+qLow1ENQkQg0iQs8GrVOIkCQg6SQ8+I SvxYRX4nf5OoLRWpc7egAgLbWunL1eqLW3IBysFb/H6FK7nedJp5Vq0gtagbwtmMrfEd 6AquYpsh9HMdOE7Gk8WKVRQman+U9NQ3m28FOi1Nup8YsRxf6vlmbM8Ey4NrlHIuzuSl ItE6FVantrocXfZkjQAj/JtpTxt6SpQaiMX5vT6b7Ab9LYvzS1j2fSx1ghRS9s1ERa1n QVg+DjOJlbQtIc2lQsoafMNU/lfcl1lPa44XQqMDgGciKVpT/TUmafplkcG2Jn3W0c4C Xmzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=2YoAYXpLUj0mTF7ivQjLncWpRXjl5q0TuUTp6E2oybw=; b=s8ptcmJL+GBXxaC/E600iakrZG/K2xz3Ij9t8xsyuIkupYzFAMpHdCePk7AQRxUoJ1 OvGcpcaiZtdgM4fWG9RLEGwsUIJLOFAKXrJ7bH6n5GMOyllEi0MspnPw/6gfsPImMXzj EY73ol/o3iUAL7KkSXIFDfovRJNpR08lzXYN4363eJcuBckDf+IZJjPj7b6xSrMdQFRx 8y40Hzhb6GurPePKrj6rIFJwfIE6/M+lZM5KvVachoKPwHWxS7OlMdvXwD/wXgAPr7lI mAdeW6/ZyULFV+OD4LfaTylWDRsQZ+hS5DMkXE9LZhZl2ijGKLU0diW0RNLoQJBr8Yvy KyrQ== X-Gm-Message-State: AOAM532+64v3iNZeraNYHrsO1xu0p6bvKZn+81xJNLScaP/52LYwTrhc L3ElHhU09aFbQXa+zKbvc7I= X-Google-Smtp-Source: ABdhPJz7ENTeFJglhhzacnfuNQ3dnl9GKQq4qqlNB1kW9MQT1RHS+CRGfVtJ6qIBn9sZxNDSFRx2vQ== X-Received: by 2002:adf:e741:: with SMTP id c1mr10503467wrn.49.1618777244301; Sun, 18 Apr 2021 13:20:44 -0700 (PDT) Received: from [192.168.1.36] (39.red-81-40-121.staticip.rima-tde.net. [81.40.121.39]) by smtp.gmail.com with ESMTPSA id j12sm19504194wro.29.2021.04.18.13.20.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 18 Apr 2021 13:20:43 -0700 (PDT) Subject: Re: [PATCH 19/26] target/mips: Move helper_cache() to tcg/sysemu/special_helper.c To: Richard Henderson , qemu-devel@nongnu.org References: <20210418163134.1133100-1-f4bug@amsat.org> <20210418163134.1133100-20-f4bug@amsat.org> <9ac752b7-8cab-2324-7086-41f1dfe17c85@linaro.org> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Message-ID: <76d990fb-dae3-2a19-ce86-98d172b48c34@amsat.org> Date: Sun, 18 Apr 2021 22:20:42 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <9ac752b7-8cab-2324-7086-41f1dfe17c85@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::42e; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-x42e.google.com X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Aleksandar Rikalo , Huacai Chen , Aurelien Jarno Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 4/18/21 9:52 PM, Richard Henderson wrote: > On 4/18/21 9:31 AM, Philippe Mathieu-Daudé wrote: >> Move helper_cache() to tcg/sysemu/special_helper.c. >> >> The CACHE opcode is privileged and is not accessible in user >> emulation. However we get a link failure when restricting the >> symbol to sysemu. For now, add a stub to satisfy linking, which >> abort if ever called. >> >> Signed-off-by: Philippe Mathieu-Daudé >> --- >>   target/mips/op_helper.c                 | 35 ------------------------- >>   target/mips/tcg/sysemu/special_helper.c | 33 +++++++++++++++++++++++ >>   target/mips/tcg/user/stubs.c            | 29 ++++++++++++++++++++ >>   target/mips/tcg/user/meson.build        |  1 + >>   4 files changed, 63 insertions(+), 35 deletions(-) >>   create mode 100644 target/mips/tcg/user/stubs.c > > You could add a different stub to translate.c instead.  See > > https://lists.gnu.org/archive/html/qemu-devel/2021-02/msg08595.html Great! I think STUB_HELPER() belong to include/exec/helper-*.h. Thanks, Phil.