qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Subject: Re: [PATCH] user-exec: abort if interrupt_request is used
Date: Sun, 31 Aug 2025 07:53:19 +1000	[thread overview]
Message-ID: <76dd4881-73dc-4849-9958-3d4ff73f8a38@linaro.org> (raw)
In-Reply-To: <20250829111110.1490546-1-pbonzini@redhat.com>

On 8/29/25 21:11, Paolo Bonzini wrote:
> cpu_interrupt() is only called by a few user-mode emulation targets:
> i386, ppc, sparc, arm.  For all of them it is dead code:
> 
> - i386 uses it for the A20 line
> 
> - ppc uses it in cpu_interrupt_exittb(), whose uses (but not the definition)
>    are guarded by CONFIG_USER_ONLY
> 
> - likewise for sparc's cpu_check_irqs()
> 
> Arm has various uses in arm_cpu_update_v* and omap_wfi_write, but they are
> also dead; disentangling the various cpregs accessors from user-mode
> emulation is a work in progress.
> 
> Signed-off-by: Paolo Bonzini<pbonzini@redhat.com>
> ---
>          A quick and dirty patch that I'd like to place before Igor's
>          https://patchew.org/QEMU/20250814160600.2327672-1-imammedo@redhat.com/,
>          to document that interrupt_request is dead for user-mode emulation.
> 
>          v2 ofhttps://patchew.org/QEMU/20250808185905.62776-1-pbonzini@redhat.com/
>          will also remove callers of cpu_interrupt() treewide.

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~


      reply	other threads:[~2025-08-30 21:54 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-29 11:11 [PATCH] user-exec: abort if interrupt_request is used Paolo Bonzini
2025-08-30 21:53 ` Richard Henderson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=76dd4881-73dc-4849-9958-3d4ff73f8a38@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).