From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2AF3C433F5 for ; Fri, 17 Sep 2021 09:05:59 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9BCF16113A for ; Fri, 17 Sep 2021 09:05:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 9BCF16113A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:33362 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mR9ok-0005Oc-NW for qemu-devel@archiver.kernel.org; Fri, 17 Sep 2021 05:05:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51076) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mR9id-0002td-QO for qemu-devel@nongnu.org; Fri, 17 Sep 2021 04:59:39 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:59971) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mR9iZ-0003SW-6i for qemu-devel@nongnu.org; Fri, 17 Sep 2021 04:59:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1631869174; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lfWLsDMcDJCBpi517s5xKISqgPEbDTZzpQo54ivTci0=; b=R12HON8PWS4LpUHMWb2cnJo4OJYd8j7zUdWru3M2Y4BICrdeSqjFCCoOVV6K5Xcw6ovvdl zZyl9S3jBGT1KStsMgQ7yWDof1iSGAto3+K64QZ2rmzbPku2VoYQ1kJZXDIRKEEfJ1qIF6 jSuKGDZCUA0E0qCj/Nh9UxyrwNboRSQ= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-558-rpwDTjGHMcGb38U-j6ET9g-1; Fri, 17 Sep 2021 04:59:31 -0400 X-MC-Unique: rpwDTjGHMcGb38U-j6ET9g-1 Received: by mail-wr1-f72.google.com with SMTP id z2-20020a5d4c82000000b0015b140e0562so3476931wrs.7 for ; Fri, 17 Sep 2021 01:59:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=lfWLsDMcDJCBpi517s5xKISqgPEbDTZzpQo54ivTci0=; b=QzJST3vAOdJ3ggA9/5NYCADNh9JTDkrmjju2FWrs3wjoIh/diD81pW6O6PynhiLFTx LNxkYmzAnGEoW4dMpbu65Vw00l/Sc28WMXnEi0ebmvpe4KmDLqm2OKTod17eKYgFw4gL uDMAdXlUFGh1j2aC2EyDnnzF758xdYHLkI2D65wsxk2wg3OVz3UdNmKfN60N9/zLRLuy cEP1qEydOJPv1MCSi5sTScNAvK17V+UfEebmhg0CVTb6yxsD+vzlkI2/KwOPGOoKq7sS 10v9TrIS3GMqXLxvQGnpIs7+zzk0ySQsruNPscRKGq/iY+ATNVGqtUPIcr7NR2hXIA5f 5fuA== X-Gm-Message-State: AOAM531meO3uYmANoKGb//3hXynE0Z9J6il+mLhsFsZ06jnkF1YCvPFm BHRoVUHG3UM/eLn3s3d2m4APIdELR5p1Hfz8IeY252PTjnU3t+1zokjtSTmdSHLekht8wjka9Gc 9hGwvp3qvjr7e1Cs= X-Received: by 2002:a5d:4d4f:: with SMTP id a15mr10883102wru.210.1631869170107; Fri, 17 Sep 2021 01:59:30 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzBoKPy3iBaYZ/w3mmEaBd+FzXZaApU+LOWk5UlLhohjIp7GB2YAvRg7pphTkr38NHiQNnAxQ== X-Received: by 2002:a5d:4d4f:: with SMTP id a15mr10883086wru.210.1631869169915; Fri, 17 Sep 2021 01:59:29 -0700 (PDT) Received: from dresden.str.redhat.com ([2a02:908:1e48:3780:4451:9a65:d4e9:9bb6]) by smtp.gmail.com with ESMTPSA id s15sm6142161wrb.22.2021.09.17.01.59.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 Sep 2021 01:59:29 -0700 (PDT) Subject: Re: [PATCH v3 04/16] iotests/migrate-bitmaps-test: delint To: John Snow , qemu-devel@nongnu.org References: <20210916040955.628560-1-jsnow@redhat.com> <20210916040955.628560-5-jsnow@redhat.com> From: Hanna Reitz Message-ID: <76e4af2b-f3f1-3642-9b2c-98b39a465601@redhat.com> Date: Fri, 17 Sep 2021 10:59:28 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210916040955.628560-5-jsnow@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=hreitz@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Received-SPF: pass client-ip=170.10.133.124; envelope-from=hreitz@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -46 X-Spam_score: -4.7 X-Spam_bar: ---- X-Spam_report: (-4.7 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.392, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-1.488, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Vladimir Sementsov-Ogievskiy , Eduardo Habkost , qemu-block@nongnu.org, Markus Armbruster , Cleber Rosa Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 16.09.21 06:09, John Snow wrote: > Mostly uninteresting stuff. Move the test injections under a function > named main() so that the variables used during that process aren't in > the global scope. > > Signed-off-by: John Snow > --- > tests/qemu-iotests/tests/migrate-bitmaps-test | 50 +++++++++++-------- > 1 file changed, 28 insertions(+), 22 deletions(-) Reviewed-by: Hanna Reitz