Re: [Qemu-devel] [PATCH] qapi: Fix some blockdev-add documentation regressions

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1443 bytes --]

On 05/23/2017 03:39 AM, Markus Armbruster wrote:
> Eric Blake <eblake@redhat.com> writes:
> 
>> In the process of getting rid of docs/qmp-commands.txt, we
>> managed to regress on any text that changed after the point
>> where the move was first branched and when the move actually
>> occurred.  For example, commit 3282eca for blockdev-snapshot
>> re-added the extra "options" layer which had been cleaned up
>> in commit 0153d2f.
>>
>> While I didn't audit for all such regressions, I did scrub
>> for all bogus uses of nested "options".
> 
> I figure anything that changed in qmp-commands.txt between the first
> base of Marc-André's work and its merge into master is at risk.
> 
> I don't know the exact first base.  "[PATCH 00/30] Move qapi
> documentation to schema (part 1/5)" was posted on 2016-09-13.  September
> 2016 looks like a fair guess.  With a bit of extra margin:

Thanks for the audit!

> 
> Please throw in a fix for the remaining regression of 'eject'.  Whether
> you squash it into this one or keep it separate is up to you.  For this
> part:
> 
> Reviewed-by: Markus Armbruster <armbru@redhat.com>

I'll post a v2, since I have another pending doc patch that hasn't been
reviewed yet, and since your audit means I need to update my commit
message anyway.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]