From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C74F9C11F65 for ; Wed, 30 Jun 2021 18:58:23 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6B6E461431 for ; Wed, 30 Jun 2021 18:58:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6B6E461431 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:45020 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lyfPi-00073W-Eo for qemu-devel@archiver.kernel.org; Wed, 30 Jun 2021 14:58:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50002) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lyfN1-0000ix-E6 for qemu-devel@nongnu.org; Wed, 30 Jun 2021 14:55:35 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:55980) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lyfMs-0006MZ-JM for qemu-devel@nongnu.org; Wed, 30 Jun 2021 14:55:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1625079325; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=YkhbS+b8YlXtwPDYG7J/rzEBZMIvHBLcES/TkwVQbKw=; b=iDh410VZ2Jl4Mif3TuAjOytJhhvYflX2DfLxxyzqFSyAb4DgTYXIw6RT9YFACbM6PdubPO Dbwu59whwrT/3tjGRq0NFWjjXHmfHOEpXLS/nuNyUDOjnPAOw4YUoldpBtoXbiPnq7Ou5Q RlS4s3nVqQ6gUd3imrztGuapNN4e65E= Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-98-JYrjBAoGMlK8CIbVhuQAqA-1; Wed, 30 Jun 2021 14:55:23 -0400 X-MC-Unique: JYrjBAoGMlK8CIbVhuQAqA-1 Received: by mail-pf1-f200.google.com with SMTP id k196-20020a6284cd0000b0290301abd2c063so2326626pfd.14 for ; Wed, 30 Jun 2021 11:55:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:reply-to:subject:to:cc:references:from :message-id:date:user-agent:mime-version:in-reply-to :content-language; bh=YkhbS+b8YlXtwPDYG7J/rzEBZMIvHBLcES/TkwVQbKw=; b=P8FYcFkp4DEVLhUY1x+HtwBg1tqsiqq2mj00Q8p6gdGefc99o8M2yvY6Bis/puK17v bmVKwk51xLZ4jwG07NS+kppdL+VypSguXrcrruobelT3/6hHAPxmVsB9S7fA6ELH9Qw5 3GHekJNV08n4Pa+ZnYNRMSz8lcj0sohl2zS2Yy1HJQ5pf+lSBWGtq2gqIf4++k7R8Hxr gApwODyRnGAFLAuSch4C0TY97gRdfU0DxV5kX1ODstXble9SEYAYVSIThw+3OGy12JLu qnGtSXoaSeAsDpPZCkb6xznFwNdqgw/nHMvAI/pkaKP9dWTvc7/unDKr6ifCJUE2vnuh FlaQ== X-Gm-Message-State: AOAM533zVohBS0VXo97bAuf1JwM+qa9WGo+EmhEIviAPNPmrbYXUK3oT CZkN93sqrkX09/B80TErmDxpyW7VdirXs1UjfVYfjCZwn06LP1hrGapsAOx7nKNfOPnKSCHFUr8 ImD6rbDJhVquKeIo= X-Received: by 2002:a63:4e42:: with SMTP id o2mr35606078pgl.49.1625079322841; Wed, 30 Jun 2021 11:55:22 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw2rvBo7iqZji5IhbhVk2zFZkPuNjrV7oKNRu9gszrlj9Wfr7olJx6VQLHIfwyp5vKIuGDoag== X-Received: by 2002:a63:4e42:: with SMTP id o2mr35606057pgl.49.1625079322620; Wed, 30 Jun 2021 11:55:22 -0700 (PDT) Received: from wainer-laptop.localdomain ([179.105.223.44]) by smtp.gmail.com with ESMTPSA id c3sm2495458pfv.56.2021.06.30.11.55.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 30 Jun 2021 11:55:22 -0700 (PDT) Subject: Re: [PATCH v2 07/12] python: update help text for check-tox To: John Snow References: <20210629164253.1272763-1-jsnow@redhat.com> <20210629164253.1272763-8-jsnow@redhat.com> From: Wainer dos Santos Moschetta Message-ID: <76f6f606-66f8-c25c-4d2a-1f71f88b2232@redhat.com> Date: Wed, 30 Jun 2021 15:55:16 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=wainersm@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="------------0FBE579D9E7540832201230D" Content-Language: en-US Received-SPF: pass client-ip=170.10.133.124; envelope-from=wainersm@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.435, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: wainersm@redhat.com Cc: Thomas Huth , Eduardo Habkost , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org, Willian Rampazzo , Cleber Rosa , =?UTF-8?Q?Alex_Benn=c3=a9e?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" This is a multi-part message in MIME format. --------------0FBE579D9E7540832201230D Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit On 6/29/21 6:27 PM, John Snow wrote: > > > On Tue, Jun 29, 2021 at 4:25 PM Wainer dos Santos Moschetta > > wrote: > > Hi John, > > On 6/29/21 1:42 PM, John Snow wrote: > > Move it up near the check-pipenv help text, and update it to > suggest parity. > > > > (At the time I first added it, I wasn't sure if I would be > keeping it, > > but I've come to appreciate it as it has actually helped uncover > bugs I > > would not have noticed without it. It should stay.) > > > > Signed-off-by: John Snow > > > Reviewed-by: Willian Rampazzo > > > --- > >   python/Makefile | 8 ++++++-- > >   1 file changed, 6 insertions(+), 2 deletions(-) > > > > diff --git a/python/Makefile b/python/Makefile > > index 07ad73ccd0..d2cfa6ad8f 100644 > > --- a/python/Makefile > > +++ b/python/Makefile > > @@ -9,13 +9,17 @@ help: > >       @echo "    Requires: Python 3.6 and pipenv." > >       @echo "    Hint (Fedora): 'sudo dnf install python3.6 pipenv'" > >       @echo "" > > +     @echo "make check-tox:" > > +     @echo "    Run tests against multiple python versions." > > +     @echo "    These tests use the newest dependencies." > > +     @echo "    Requires: Python 3.6 - 3.10, and tox." > > +     @echo "    Hint (Fedora): 'sudo dnf install python3-tox > python3.10'" > > +     @echo "" > > Somewhat related... in my system I don't have all supported python > versions installed, thus check-tox fails. > > Instead, maybe, you could configure tox (as below) to test to > whatever > supported versions the developer have installed in the system; and on > absence of some versions it won't fail the tests entirely. > > diff --git a/python/setup.cfg b/python/setup.cfg > index e730f208d3..1db8aaf340 100644 > --- a/python/setup.cfg > +++ b/python/setup.cfg > @@ -123,6 +123,7 @@ multi_line_output=3 > >   [tox:tox] >   envlist = py36, py37, py38, py39, py310 > +skip_missing_interpreters=true > > > Didn't know this was an option, to be honest ... I wonder if it can be > toggled on/off easily? I like the idea that it will fail if we don't > set up the CI environment correctly instead of succeeding quietly. > > Though, you're right, some is better than none. Send a patch if you want? I just sent a patch. Message-Id: <20210630184546.456582-1-wainersm@redhat.com> - Wainer > > --js --------------0FBE579D9E7540832201230D Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 8bit


On 6/29/21 6:27 PM, John Snow wrote:


On Tue, Jun 29, 2021 at 4:25 PM Wainer dos Santos Moschetta <wainersm@redhat.com> wrote:
Hi John,

On 6/29/21 1:42 PM, John Snow wrote:
> Move it up near the check-pipenv help text, and update it to suggest parity.
>
> (At the time I first added it, I wasn't sure if I would be keeping it,
> but I've come to appreciate it as it has actually helped uncover bugs I
> would not have noticed without it. It should stay.)
>
> Signed-off-by: John Snow <jsnow@redhat.com>
> Reviewed-by: Willian Rampazzo <willianr@redhat.com>
> ---
>   python/Makefile | 8 ++++++--
>   1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/python/Makefile b/python/Makefile
> index 07ad73ccd0..d2cfa6ad8f 100644
> --- a/python/Makefile
> +++ b/python/Makefile
> @@ -9,13 +9,17 @@ help:
>       @echo "    Requires: Python 3.6 and pipenv."
>       @echo "    Hint (Fedora): 'sudo dnf install python3.6 pipenv'"
>       @echo ""
> +     @echo "make check-tox:"
> +     @echo "    Run tests against multiple python versions."
> +     @echo "    These tests use the newest dependencies."
> +     @echo "    Requires: Python 3.6 - 3.10, and tox."
> +     @echo "    Hint (Fedora): 'sudo dnf install python3-tox python3.10'"
> +     @echo ""

Somewhat related... in my system I don't have all supported python
versions installed, thus check-tox fails.

Instead, maybe, you could configure tox (as below) to test to whatever
supported versions the developer have installed in the system; and on
absence of some versions it won't fail the tests entirely.

diff --git a/python/setup.cfg b/python/setup.cfg
index e730f208d3..1db8aaf340 100644
--- a/python/setup.cfg
+++ b/python/setup.cfg
@@ -123,6 +123,7 @@ multi_line_output=3

  [tox:tox]
  envlist = py36, py37, py38, py39, py310
+skip_missing_interpreters=true

Didn't know this was an option, to be honest ... I wonder if it can be toggled on/off easily? I like the idea that it will fail if we don't set up the CI environment correctly instead of succeeding quietly.

Though, you're right, some is better than none. Send a patch if you want?


I just sent a patch. Message-Id: <20210630184546.456582-1-wainersm@redhat.com>

- Wainer


--js
--------------0FBE579D9E7540832201230D--