From: Richard Henderson <richard.henderson@linaro.org>
To: Don Porter <porter@cs.unc.edu>, qemu-devel@nongnu.org
Cc: dave@treblig.org, peter.maydell@linaro.org, nadav.amit@gmail.com,
philmd@linaro.org, berrange@redhat.com
Subject: Re: [PATCH v4 1/7] Code motion: expose some TCG definitions for page table walk consolidation.
Date: Wed, 24 Jul 2024 13:14:54 +1000 [thread overview]
Message-ID: <7708addb-1c74-4d9b-acda-a46c5f15509f@linaro.org> (raw)
In-Reply-To: <20240723010545.3648706-2-porter@cs.unc.edu>
On 7/23/24 11:05, Don Porter wrote:
> Signed-off-by: Don Porter <porter@cs.unc.edu>
> ---
> include/hw/core/sysemu-cpu-ops.h | 6 +++++
> target/i386/cpu.h | 5 ++--
> target/i386/helper.c | 36 +++++++++++++++++++++++++++
> target/i386/tcg/helper-tcg.h | 32 ++++++++++++++++++++++++
> target/i386/tcg/seg_helper.c | 36 ---------------------------
> target/i386/tcg/sysemu/excp_helper.c | 37 +---------------------------
> 6 files changed, 77 insertions(+), 75 deletions(-)
>
> diff --git a/include/hw/core/sysemu-cpu-ops.h b/include/hw/core/sysemu-cpu-ops.h
> index 24d003fe04..4c94e51267 100644
> --- a/include/hw/core/sysemu-cpu-ops.h
> +++ b/include/hw/core/sysemu-cpu-ops.h
> @@ -12,6 +12,12 @@
>
> #include "hw/core/cpu.h"
>
> +typedef enum TranslateFaultStage2 {
> + S2_NONE,
> + S2_GPA,
> + S2_GPT,
> +} TranslateFaultStage2;
No, you can't move an x86-specific item like this into common code.
You're doing something wrong in the abstraction.
r~
next prev parent reply other threads:[~2024-07-24 3:16 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-23 1:05 [PATCH v4 0/7] Rework x86 page table walks Don Porter
2024-07-23 1:05 ` [PATCH v4 1/7] Code motion: expose some TCG definitions for page table walk consolidation Don Porter
2024-07-24 3:14 ` Richard Henderson [this message]
2024-07-23 1:05 ` [PATCH v4 2/7] Import vmcs12 definition from Linux/KVM Don Porter
2024-07-24 1:34 ` Dr. David Alan Gilbert
2024-07-24 3:18 ` Richard Henderson
2024-07-23 1:05 ` [PATCH v4 3/7] Add an "info pg" command that prints the current page tables Don Porter
2024-07-24 3:33 ` Richard Henderson
2024-07-26 20:07 ` Don Porter
2024-07-23 1:05 ` [PATCH v4 4/7] Convert 'info tlb' to use generic iterator Don Porter
2024-07-27 20:47 ` Dr. David Alan Gilbert
2024-07-23 1:05 ` [PATCH v4 5/7] Convert 'info mem' " Don Porter
2024-07-23 1:05 ` [PATCH v4 6/7] Convert x86_cpu_get_memory_mapping() to use generic iterators Don Porter
2024-07-23 1:05 ` [PATCH v4 7/7] Convert x86_mmu_translate() to use common code Don Porter
2024-07-24 3:39 ` [PATCH v4 0/7] Rework x86 page table walks Richard Henderson
2024-08-02 16:53 ` Don Porter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7708addb-1c74-4d9b-acda-a46c5f15509f@linaro.org \
--to=richard.henderson@linaro.org \
--cc=berrange@redhat.com \
--cc=dave@treblig.org \
--cc=nadav.amit@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=porter@cs.unc.edu \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).