From: Richard Henderson <richard.henderson@linaro.org>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>, qemu-devel@nongnu.org
Cc: Aurelien Jarno <aurelien@aurel32.net>,
Corey Minyard <cminyard@mvista.com>,
Jiaxun Yang <jiaxun.yang@flygoat.com>,
BALATON Zoltan <balaton@eik.bme.hu>
Subject: Re: [PATCH] hw/mips/malta: Use sdram_type enum from 'hw/i2c/smbus_eeprom.h'
Date: Tue, 10 Oct 2023 09:38:36 -0700 [thread overview]
Message-ID: <771f5bd6-a09e-4a3a-a6cc-0203dccc9683@linaro.org> (raw)
In-Reply-To: <20231009092127.49778-1-philmd@linaro.org>
On 10/9/23 02:21, Philippe Mathieu-Daudé wrote:
> Since commit 93198b6cad ("i2c: Split smbus into parts") the SDRAM
> types are enumerated as sdram_type in "hw/i2c/smbus_eeprom.h".
>
> Using the enum removes this global shadow warning:
>
> hw/mips/malta.c:209:12: error: declaration shadows a variable in the global scope [-Werror,-Wshadow]
> enum { SDR = 0x4, DDR2 = 0x8 } type;
> ^
> include/hw/i2c/smbus_eeprom.h:33:19: note: previous declaration is here
> enum sdram_type { SDR = 0x4, DDR = 0x7, DDR2 = 0x8 };
> ^
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2023-10-10 16:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-09 9:21 [PATCH] hw/mips/malta: Use sdram_type enum from 'hw/i2c/smbus_eeprom.h' Philippe Mathieu-Daudé
2023-10-09 11:17 ` BALATON Zoltan
2023-10-10 16:38 ` Richard Henderson [this message]
2023-10-16 9:06 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=771f5bd6-a09e-4a3a-a6cc-0203dccc9683@linaro.org \
--to=richard.henderson@linaro.org \
--cc=aurelien@aurel32.net \
--cc=balaton@eik.bme.hu \
--cc=cminyard@mvista.com \
--cc=jiaxun.yang@flygoat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).