Re: [PATCH] scripts/qmp: delete 'qmp' script

[Eric Blake <eblake@redhat.com>]

On 10/19/20 4:04 PM, John Snow wrote:
> This script has not seen a patch that was specifically for this script
> since it was moved to this location in 2013, and I doubt it is used. It
> uses "man qmp" for its help message, which does not exist. It also
> presumes there is a manual page for qmp-XXX, for each defined qmp
> command XXX. I don't think that's true.
> 
> The format it expects arguments in is something like:
> 
> block-dirty-bitmap-add --node=foo --name=bar
> 
> and has no capacity to support nested JSON arguments, either.
> 
> Most developers use either qmp-shell or socat (or pasting JSON directly
> into qmp stdio), so this duplication and additional alternate syntax is
> not helpful.
> 
> Remove it. Leave a breadcrumb script just in case, to be removed next
> release cycle.
> 
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
>   scripts/qmp/qmp | 131 +++---------------------------------------------
>   1 file changed, 7 insertions(+), 124 deletions(-)
> 
> -sys.path.append(os.path.join(os.path.dirname(__file__), '..', '..', 'python'))
> -from qemu.qmp import QEMUMonitorProtocol
> +print('''This unmaintained and undocumented script was removed in preference
> +for qmp-shell. The assumption is that most users are using either
> +qmp-shell, socat, or pasting/piping JSON into stdio. The duplication of
> +facilities here is unwanted, and the divergence of syntax harmful.''',
> +      file=sys.stderr)
>   

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org