From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47265)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1bXsw2-0005Up-Fk
	for qemu-devel@nongnu.org; Thu, 11 Aug 2016 12:34:23 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1bXsvw-0006nr-Ds
	for qemu-devel@nongnu.org; Thu, 11 Aug 2016 12:34:21 -0400
Received: from mx5-phx2.redhat.com ([209.132.183.37]:41193)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1bXsvw-0006nj-5Y
	for qemu-devel@nongnu.org; Thu, 11 Aug 2016 12:34:16 -0400
Date: Thu, 11 Aug 2016 12:34:13 -0400 (EDT)
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <777265882.1234102.1470933253966.JavaMail.zimbra@redhat.com>
In-Reply-To: <CAC2QTZas+WvfREPrP7pmps+fFzUzGimao7DSLNSPopqbBu6+KQ@mail.gmail.com>
References: <CAC2QTZaeboA=HZ49irTjCfcYAjp80JiaTX3E=mOd8WZ3scADdA@mail.gmail.com>
	<CAC2QTZZM0vcm48tCfvosH+kFuscV7UMVMNDyzkEMvF5dm+2shg@mail.gmail.com>
	<de73cbc1-dfbd-fc21-cc9a-b4f340c5e089@redhat.com>
	<CAC2QTZaa-VBfoooggEmJZ8EWiNUZZeDC8PThOZQKh2Mmhp3=Pg@mail.gmail.com>
	<CAC2QTZbxNkNZsz0rFmyju_QnS6qTdjKqtrFbnnFBO=B1Z8x-cw@mail.gmail.com>
	<CAC2QTZas+WvfREPrP7pmps+fFzUzGimao7DSLNSPopqbBu6+KQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] Dangling change state handler while hot unplugging
 ahci adapter
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Ashijeet Acharya <ashijeetacharya@gmail.com>
Cc: John Snow <jsnow@redhat.com>, QEMU Developers <qemu-devel@nongnu.org>


> I think we should do
> 
> s->vmstate = qemu_add_vm_change_state_handler(ide_restart_cb, bus);
> instead of
> qemu_add_vm_change_state_handler(ide_restart_cb, bus);
> 
> in ide_register_restart_cb() in hw/ide/core.c to store the returned
> pointer to memory to avoid a possible memory leak I guess and
> introduce a VMChangeStateEntry field in struct AHCIState to handle
> this. Same can then further be used with
> qemu_del_vm_change_state_handler() in ahci_unrealize() to free things
> up.

Yes, this is correct. Thanks!

Paolo